http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15107&action=edit Bug 9555: Template files contain single quote strings Test plan: - launch the test xt/single_quotes.t, there are 3 occurrences - apply this patch - launch the test. It will pass with success - Check that there is no regression on the 2 modified intranet files and the calendar still works at the OPAC. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15107|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15176&action=edit Bug 9555: Template files contain single quote strings Test plan: - launch the test xt/single_quotes.t, there are 3 occurrences - apply this patch - launch the test. It will pass with success - Check that there is no regression on the 2 modified intranet files and the calendar still works at the OPAC. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15176|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15525&action=edit Bug 9555: Template files contain single quote strings Test plan: - launch the test xt/single_quotes.t, there are 3 occurrences - apply this patch - launch the test. It will pass with success - Check that there is no regression on the 2 modified intranet files and the calendar still works at the OPAC. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 9714 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15525|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15963|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15988&action=edit Bug 9555: Another template contains single quotes in a js string Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: The xt/single_quotes.t test failed before this patch # Failed test 'Files do not contain single quotes _(' ' # at xt/single_quotes.t line 39. # Files list: # manage.tt: return GB_showCenter(_('Export patron cards'), "/cgi-bin/koha/patroncards/print.pl?" + getstr, 700, 800); # Looks like you failed 1 test of 1. xt/single_quotes.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Now all tests pass. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.