http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 8592 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11455&action=edit Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls When the DataTables plugin was upgraded the DataTables CSS was not updated at the same time, causing problems in the display due to changes in how the plugin works. The DataTables upgrade added text lables to the image-only buttons in order to improve accessibility. This patch revises the CSS and the four_button pager modification to conform with the upgrade. To test, please view tables which use each of three types of pagers: default two-button (ex: circ/pendingreserves), custom four-button (ex: members/readingrec.pl) and full (ex: tools/quotes.pl). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11455|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11459&action=edit Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls When the DataTables plugin was upgraded the DataTables CSS was not updated at the same time, causing problems in the display due to changes in how the plugin works. The DataTables upgrade added text lables to the image-only buttons in order to improve accessibility. This patch revises the CSS and the four_button pager modification to conform with the upgrade. To test, please view tables which use each of three types of pagers: default two-button (ex: circ/pendingreserves), custom four-button (ex: members/readingrec.pl) and full (ex: tools/quotes.pl). Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #3)

Created attachment 11459 [details] Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

patch looks good, passing QA fyi: we need to add .css and .js validation tests to qa-tools too... :) mason@xen1:~/git/head$ koha-qa.pl * 35aa6ba Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls koha-tmpl/intranet-tmpl/prog/en/css/datatables.css koha-tmpl/intranet-tmpl/prog/en/js/datatables.js - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master. (Not sure the commit e77461a3cfb18a851668b99d9d6d323b9fefceb4 that introduced the problem is in 3.8, so maybe not for 3.8) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.