[Bug 40087] New: Remove unused C4::Scrubber profiles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 Bug ID: 40087 Summary: Remove unused C4::Scrubber profiles Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org As far as I can tell, the C4::Scrubber profiles "staff" and "tag" are not actually used in Koha. "tag" is actually the same as "default", and opac-tags.pl just uses "default". There's no point to "tag". Now "staff" is actually dangerous, because it doesn't do any scrubbing. It allows all elements and all attributes. We never want to use it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 183021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183021&action=edit Bug 40087: Remove "tag" and "staff" scrubber profiles This patch removes unused "tag" and "staff" scrubber profiles. Test plan: 0. Apply the patch 1. prove t/Koha/Plugins/HtmlScrubber.t 2. prove t/Scrubber.t 3. Grep around the code for C4::Scrubber and make sure "tag" and "staff" aren't used as arguments for C4::Scrubber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39860 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove unused C4::Scrubber |Remove unused C4::Scrubber |profiles |profiles "tag" and "staff" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- prove t/Scrubber.t fails for me (both tests pass before the patch): t/Scrubber.t .. 1/32 New called with unrecognized type 'tag' at t/Scrubber.t line 60. # Looks like your test exited with 255 just after 18. t/Scrubber.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 14/32 subtests Test Summary Report ------------------- t/Scrubber.t (Wstat: 65280 (exited 255) Tests: 18 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 32 tests but ran 18. Files=1, Tests=18, 1 wallclock secs ( 0.01 usr 0.01 sys + 0.22 cusr 0.05 csys = 0.29 CPU) Result: FAIL Not sure what I'm looking for, for step 3 of the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to David Nind from comment #2)
prove t/Scrubber.t fails for me (both tests pass before the patch):
t/Scrubber.t .. 1/32 New called with unrecognized type 'tag' at t/Scrubber.t line 60. # Looks like your test exited with 255 just after 18. t/Scrubber.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 14/32 subtests
Test Summary Report ------------------- t/Scrubber.t (Wstat: 65280 (exited 255) Tests: 18 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 32 tests but ran 18. Files=1, Tests=18, 1 wallclock secs ( 0.01 usr 0.01 sys + 0.22 cusr 0.05 csys = 0.29 CPU) Result: FAIL
Not sure what I'm looking for, for step 3 of the test plan.
Thanks, David. I actually ran it with "perl t/Scrubber.t" originally and it looks like I missed the failure because of the lack of color-coding haha. I'll get that fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 183032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183032&action=edit Bug 40087: Fix t/Scrubber.t unit test Remove "tag" and "staff" and add the missing "note" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Round 2... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183021|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 183033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183033&action=edit Bug 40087: Remove "tag" and "staff" scrubber profiles This patch removes unused "tag" and "staff" scrubber profiles. Test plan: 0. Apply the patch 1. prove t/Koha/Plugins/HtmlScrubber.t 2. prove t/Scrubber.t 3. Grep around the code for C4::Scrubber and make sure "tag" and "staff" aren't used as arguments for C4::Scrubber Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183032|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 183034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183034&action=edit Bug 40087: Fix t/Scrubber.t unit test Remove "tag" and "staff" and add the missing "note" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to David Cook from comment #3)
I'll get that fixed.
Thanks David, signed off. For step 3, not sure exactly what to look for. With a git grep "C4::Scrubber", I can't see any mention of tag and staff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183033|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 183036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183036&action=edit Bug 40087: Remove "tag" and "staff" scrubber profiles This patch removes unused "tag" and "staff" scrubber profiles. Test plan: 0. Apply the patch 1. prove t/Koha/Plugins/HtmlScrubber.t 2. prove t/Scrubber.t 3. Grep around the code for C4::Scrubber and make sure "tag" and "staff" aren't used as arguments for C4::Scrubber Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183034|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 183037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183037&action=edit Bug 40087: Fix t/Scrubber.t unit test Remove "tag" and "staff" and add the missing "note" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40089 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40089 [Bug 40089] Add a less permissive C4::Scrubber profile to replace staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes unused "tag" release notes| |and "staff" scrubber | |profiles from the code for | |the scrubber module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.01 |25.11.00,25.05.01,24.11.08 released in| | --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40087 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42047 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org