[Bug 21612] New: Incorrect GROUP BY in Koha::Virtualshelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Bug ID: 21612 Summary: Incorrect GROUP BY in Koha::Virtualshelves Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Same as commit 7e220e0d8f107cce63f32bfaa1919c04b4dea6e2 Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record for get_private_shelves, get_public_shelves and get_some_shelves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80883&action=edit Bug 21612: Remove incorrect GROUP BY's from Koha::VirtualShelves 'koha_kohadev.me.shelfname' isn't in GROUP BY Same as commit 7e220e0d8f107cce63f32bfaa1919c04b4dea6e2 Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record Test plan: - Add public and privates shelves - Shares some of them - List them => The correct numbers of shelves must be displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- To test this patch you will need the patches from bug 21610, otherwise you will get another failure when trying to create a new list: Incorrect integer value: '' for column 'allow_change_from_others' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80883|0 |1 is obsolete| | --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 81164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81164&action=edit Bug 21612: Remove incorrect GROUP BY's from Koha::VirtualShelves 'koha_kohadev.me.shelfname' isn't in GROUP BY Same as commit 7e220e0d8f107cce63f32bfaa1919c04b4dea6e2 Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record Test plan: - Add public and privates shelves - Shares some of them - List them => The correct numbers of shelves must be displayed Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81164|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 81261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81261&action=edit Bug 21612: Remove incorrect GROUP BY's from Koha::VirtualShelves 'koha_kohadev.me.shelfname' isn't in GROUP BY Same as commit 7e220e0d8f107cce63f32bfaa1919c04b4dea6e2 Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record Test plan: - Add public and privates shelves - Shares some of them - List them => The correct numbers of shelves must be displayed Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I pass for sql modes in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org