[Bug 11429] New: Add a link to basketgroup in basket detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 Bug ID: 11429 Summary: Add a link to basketgroup in basket detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.saby@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org Now that bug 9807 is pushed, we can display closed basketgroups without reopening them. We can use this new behavior for safely making links to basketgroups in basket detail page. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mathieu.saby@univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 23702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23702&action=edit [PATCH] Bug 11429 : Add a link to basketgroup in basket detail page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link arround the name, so that the librarian could easily go to the basketgroup from the basket. Test: Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23702|0 |1 is obsolete| | --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 23753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23753&action=edit [PATCH] Bug 11429 : Add a link to basketgroup in basket detail page If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link around the basketgroup name if the librarian has permission to manage basketgroups. Test: A. With a librarian with rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup B. With a librarian WITHOUT rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is not a link -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23753|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24511&action=edit Bug 11429 : Add a link to basketgroup in basket detail page If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link around the basketgroup name if the librarian has permission to manage basketgroups. Test: A. With a librarian with rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup B. With a librarian WITHOUT rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is not a link Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24513&action=edit Bug 11429: Manage display for basketgroup without name If a basketgroup does not have a name, the link was ' (closed)' Now it is "Basket group no. ID (closed)". This is used on the acqui/basketgroup.pl?booksellerid=XX page Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24511|0 |1 is obsolete| | Attachment #24513|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24553&action=edit [PASSED QA] Bug 11429 : Add a link to basketgroup in basket detail page If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link around the basketgroup name if the librarian has permission to manage basketgroups. Test: A. With a librarian with rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup B. With a librarian WITHOUT rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is not a link Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24554&action=edit [PASSED QA] Bug 11429: Manage display for basketgroup without name If a basketgroup does not have a name, the link was ' (closed)' Now it is "Basket group no. ID (closed)". This is used on the acqui/basketgroup.pl?booksellerid=XX page Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Adds a link to the basket group page on the basket summary page. The link only appears when the basket group is closed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org