[Bug 18095] New: Batch item modification: Better message if no item is modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095 Bug ID: 18095 Summary: Batch item modification: Better message if no item is modified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org If no item is modified, the result page of Batch item modification says: "item(s) modified (with fields modified)." The message should be: "No items modified" To reproduce: - Go to Tools -> Batch item modification - Put a barcode in and click Continue - Do not make any changes and/or deselect all item(s) - Click "Save" => Result message reads: "item(s) modified (with fields modified)." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 60119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60119&action=edit Bug 18095: Batch item modification: Better message if no item is modified If no item is modified, the result page of Batch item modification says: "item(s) modified (with fields modified)." The message should be: "No items modified" To reproduce: - Go to Tools -> Batch item modification - Put a barcode in and click Continue - Do not make any changes and/or deselect all item(s) - Click "Save" => Result message reads: "item(s) modified (with fields modified)." To test: - Apply patch - Repeat steps above - Verify that message makes sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60119|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 60128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60128&action=edit Bug 18095: Batch item modification: Better message if no item is modified If no item is modified, the result page of Batch item modification says: "item(s) modified (with fields modified)." The message should be: "No items modified" To reproduce: - Go to Tools -> Batch item modification - Put a barcode in and click Continue - Do not make any changes and/or deselect all item(s) - Click "Save" => Result message reads: "item(s) modified (with fields modified)." To test: - Apply patch - Repeat steps above - Verify that message makes sense. NOTE: Also tested positive case with actual field change. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60128|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60178&action=edit Bug 18095: Batch item modification: Better message if no item is modified If no item is modified, the result page of Batch item modification says: "item(s) modified (with fields modified)." The message should be: "No items modified" To reproduce: - Go to Tools -> Batch item modification - Put a barcode in and click Continue - Do not make any changes and/or deselect all item(s) - Click "Save" => Result message reads: "item(s) modified (with fields modified)." To test: - Apply patch - Repeat steps above - Verify that message makes sense. NOTE: Also tested positive case with actual field change. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18095 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.10 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org