[Bug 8035] New: bibs with comments show an error in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Priority: P5 - low Change sponsored?: --- Bug ID: 8035 Assignee: gmcharlt@gmail.com Summary: bibs with comments show an error in opac Severity: critical Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha This one is a doozy! and it was a hard one to track down - let me know if you need me to clarify these steps. I tested on 3.8 on two servers and it happens on both. Steps to reproduce: 1. add a comment to a record in the opac 2. approve the comment in the staff client 3. view the record in the opac 4. error appears: Software error: Undefined subroutine &main::format_date called at /home/load02/kohaclone/opac/opac-detail.pl line 654. For help, please send mail to the webmaster (webmaster@Loader), giving this error message and the time and date of the error. 5. go back to comment moderation in the staff client and comment has been deleted (or at least doesn't show on the approved comments or pending comments tab) 6. go back to record in the opac and the bib is now visible without error and there is no comment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9452&action=edit Bug 8035 - bibs with comments show an error in opac If a record has any approved comments, viewing the record details in the opac will error out with the following message: Undefined subroutine &main::format_date called at /home/load02/kohaclone/opac/opac-detail.pl line 654. This is caused by a use of C4::Dates::format_date without adding a use call to the head of the file. One line fix, adds 'use C4::Dates qw(format_date);' to the head of the file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle.m.hall@gmail.com Assignee|gmcharlt@gmail.com |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9452|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9453&action=edit [SIGNED-OFF] Bug 8035 - bibs with comments show an error in opac If a record has any approved comments, viewing the record details in the opac will error out with the following message: Undefined subroutine &main::format_date called at /home/load02/kohaclone/opac/opac-detail.pl line 654. This is caused by a use of C4::Dates::format_date without adding a use call to the head of the file. One line fix, adds 'use C4::Dates qw(format_date);' to the head of the file. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Elliott Davis <tdavis@uttyler.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tdavis@uttyler.edu --- Comment #3 from Elliott Davis <tdavis@uttyler.edu> --- This patch looks/works fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Elliott Davis <tdavis@uttyler.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Elliott Davis <tdavis@uttyler.edu> --- I hate to remove a pass but I was talk to chris about this patch earlier and it actually needs to use this:http://wiki.koha-community.org/wiki/Coding_Guidelines#Displaying_dates This should make the transition easier when we migrate to Koha::Dates giving us a single point of switching. The line that should actually be corrected is the line calling format_date should be removed and the date should be formatted in the template. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9453|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9471&action=edit Bug 8035 - bibs with comments show an error in opac If a record has any approved comments, viewing the record details in the opac will error out with the following message: Undefined subroutine &main::format_date called at /home/load02/kohaclone/opac/opac-detail.pl line 654. This is caused by a use of C4::Dates::format_date without adding a use call to the head of the file. Removing the call is the only change necessary. The dates are already being filtered by $KohaDates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Elliott Davis <tdavis@uttyler.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #6 from Ian Walls <koha.sekjal@gmail.com> --- Removes bad subroutine call to no-longer-included module. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- This will be in 3.8.1 Please don't forget to add your sign off if you sign off, this one only has pauls signoff on it (now mine) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8035 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- *** Bug 8114 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org