https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27754 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117173&action=edit Bug 27754: Correct eslint errors in basket.js This patch makes minor changes to basket.js in the staff interface templates in order to quiet warnings from ESLint. Besides whitespace, most changes are to correct undeclared or unnecessarily declared variables. To test, apply the patch and verify that the cart still works correctly. - Perform a catalog search in the staff interface. - Test adding single or multiple items to the cart from the search results page. - Testing adding and removing titles to the cart from the bibliographic detail page. - Open the cart and test the various controls in the toolbar to confirm that they still work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27754 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117173|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 117229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117229&action=edit Bug 27754: Correct eslint errors in basket.js This patch makes minor changes to basket.js in the staff interface templates in order to quiet warnings from ESLint. Besides whitespace, most changes are to correct undeclared or unnecessarily declared variables. To test, apply the patch and verify that the cart still works correctly. - Perform a catalog search in the staff interface. - Test adding single or multiple items to the cart from the search results page. - Testing adding and removing titles to the cart from the bibliographic detail page. - Open the cart and test the various controls in the toolbar to confirm that they still work correctly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27754 --- Comment #4 from David Nind <david@davidnind.com> --- Also, no ESLint warnings or errors identified using the Atom text editor and the linter-eslint package. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27754 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117229|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117419&action=edit Bug 27754: Correct eslint errors in basket.js This patch makes minor changes to basket.js in the staff interface templates in order to quiet warnings from ESLint. Besides whitespace, most changes are to correct undeclared or unnecessarily declared variables. To test, apply the patch and verify that the cart still works correctly. - Perform a catalog search in the staff interface. - Test adding single or multiple items to the cart from the search results page. - Testing adding and removing titles to the cart from the bibliographic detail page. - Open the cart and test the various controls in the toolbar to confirm that they still work correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27754 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27754 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.04 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27754 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.