[Bug 18901] New: Sysprefs translation: translate only *.pref files ( not *.pref*)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Bug ID: 18901 Summary: Sysprefs translation: translate only *.pref files (not *.pref*) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Text editors can create temporary files in this folder and this can confuse the translator. For instance, vim can create a file named '.opac.pref.swp' which will make the translator dies with the following error message: Can't use string ("b0VIM 8.0") as a HASH ref while "strict refs" in use at LangInstaller.pm line 248. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 64846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64846&action=edit Bug 18901: Sysprefs translation: translate only *.pref files (not *.pref*) Text editors can create temporary files in this folder and this can confuse the translator. For instance, vim can create a file named '.opac.pref.swp' which will make the translator dies with the following error message: Can't use string ("b0VIM 8.0") as a HASH ref while "strict refs" in use at LangInstaller.pm line 248. Test plan: 1. echo 'Oops' > .../en/modules/admin/preferences/whatever.pref.whatever 2. cd misc/translator && ./translate update fr-FR 3. Verify that you have the error message mentioned above 4. Apply patch 5. cd misc/translator && ./translate update fr-FR 6. No more errors! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64846|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 64932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64932&action=edit Bug 18901: Sysprefs translation: translate only *.pref files (not *.pref*) Text editors can create temporary files in this folder and this can confuse the translator. For instance, vim can create a file named '.opac.pref.swp' which will make the translator dies with the following error message: Can't use string ("b0VIM 8.0") as a HASH ref while "strict refs" in use at LangInstaller.pm line 248. Test plan: 1. echo 'Oops' > .../en/modules/admin/preferences/whatever.pref.whatever 2. cd misc/translator && ./translate update fr-FR 3. Verify that you have the error message mentioned above 4. Apply patch 5. cd misc/translator && ./translate update fr-FR 6. No more errors! Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64932|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65005&action=edit Bug 18901: Sysprefs translation: translate only *.pref files (not *.pref*) Text editors can create temporary files in this folder and this can confuse the translator. For instance, vim can create a file named '.opac.pref.swp' which will make the translator dies with the following error message: Can't use string ("b0VIM 8.0") as a HASH ref while "strict refs" in use at LangInstaller.pm line 248. Test plan: 1. echo 'Oops' > .../en/modules/admin/preferences/whatever.pref.whatever 2. cd misc/translator && ./translate update fr-FR 3. Verify that you have the error message mentioned above 4. Apply patch 5. cd misc/translator && ./translate update fr-FR 6. No more errors! Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65006&action=edit Bug 18901: [QA Follow-up] Do not translate zzpref either Adding one backslash makes a difference :) We need to escape the dot in the regex to exclude a file like zzpref from translation too. Perfect_regexes++ Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.10. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #8 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org