[Bug 13469] New: Unapi path to XSLTs is wrong in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Bug ID: 13469 Summary: Unapi path to XSLTs is wrong in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Currently, Unapi points to C4::Context->config('intranetdir')."/koha-tmpl/intranet-tmpl/prog/en/xslt/". However, it should point to C4::Context->config('intrahtdocs')."/prog/en/xslt/". The first path is set up just to work with a Git install, while the latter will work on every install. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 34444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34444&action=edit Bug 13469 - Unapi path to XSLTs is wrong in OPAC The Unapi path to XSLTs is wrong in the OPAC. Unfortunately, it's coded to work just for Git installs, which makes it tough to test. _TEST PLAN_ Before applying: 1) Go to http://GIT-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) If the biblionumber exists, it should show you the record in OAI_DC format. 3) Go to http://REGULAR-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 4) You should get a software error Apply the patch. After applying: 1) Refresh the page for http://yourgitinstall/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) It should work exactly the same as before. Thorough testers: 1) Push the code to that regular test install 2) Try the link again. It will properly show the converted record now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34444|0 |1 is obsolete| | --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 34484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34484&action=edit Bug 13469 - Unapi path to XSLTs is wrong in OPAC The Unapi path to XSLTs is wrong in the OPAC. Unfortunately, it's coded to work just for Git installs, which makes it tough to test. _TEST PLAN_ Before applying: 1) Go to http://GIT-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) If the biblionumber exists, it should show you the record in OAI_DC format. 3) Go to http://REGULAR-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 4) You should get a software error Apply the patch. After applying: 1) Refresh the page for http://yourgitinstall/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) It should work exactly the same as before. Thorough testers: 1) Push the code to that regular test install 2) Try the link again. It will properly show the converted record now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Verified that single install intrahtdocs==/usr/share/koha/clone1712/intranet/htdocs/intranet-tmpl plus "/prog/en/xslt/" is the location for the required xslt files. Script unapi in git install is still fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34484|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34530&action=edit [PASSED QA] Bug 13469 - Unapi path to XSLTs is wrong in OPAC The Unapi path to XSLTs is wrong in the OPAC. Unfortunately, it's coded to work just for Git installs, which makes it tough to test. _TEST PLAN_ Before applying: 1) Go to http://GIT-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) If the biblionumber exists, it should show you the record in OAI_DC format. 3) Go to http://REGULAR-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 4) You should get a software error Apply the patch. After applying: 1) Refresh the page for http://yourgitinstall/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) It should work exactly the same as before. Thorough testers: 1) Push the code to that regular test install 2) Try the link again. It will properly show the converted record now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Verified that single install intrahtdocs==/usr/share/koha/clone1712/intranet/htdocs/intranet-tmpl plus "/prog/en/xslt/" is the location for the required xslt files. Script unapi in git install is still fine. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x, will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 CC| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13922 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org