[Bug 40504] New: ILL requests should have ability to assign staff to manage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Bug ID: 40504 Summary: ILL requests should have ability to assign staff to manage Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melander@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com It would be nice if staff could be assigned to manage a request. This is something available for purchase suggestions and it would be nice for ILL requests as well. It would be especially helpful for large consortia that have to manage lots of requests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Jeremy Evans <jeremy.evans@ukhsa.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187906&action=edit Bug 40504: Preparation: Abstract 'managed by' functionality from suggestions Move 'managed by' and 'restore previous manager' form and show functionality to reusable .inc files -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187907&action=edit Bug 40504: Preparation: Add empty_table_settings option to patron_search_js This is required for ILL 'select manager' functionality, as table_settings are already defined there and the user modal table will pick that up unless explicitly stated to not use it, thus empty_table_settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187908&action=edit Bug 40504: Preparation: Disambiguation of .clear_search This is required, or clicking 'Clear' on the ILL patron search modal will trigger this event listener and cause a JS error, as the 'regular' ILL table is not shown/initialized when editing an ILL request -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187909&action=edit Bug 40504: Add ill/users API endpoint Required to get users filtered by 'ill' permission for patron search modal prove t/db_dependent/api/v1/ill_users.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187910&action=edit Bug 40504: dbic -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #6 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187911&action=edit Bug 40504: Add 'managedby' to illrequests This also includes a 'manager' accessor which returns the Koha::Patron object -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187912&action=edit Bug 40504: UI improvements This turns the 'Select manager' and 'Restore manager' actions to proper buttons, well aligned in where they are displayed. The 'Select manager' functionality in the suggestions table page is also updated to make use of the same reusable button block -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187913&action=edit Bug 40504: Auto functionality: - The staff member who creates a new ILL request is automatically assigned as its manager. - No manager is assigned to ILL requests made by users without 'ill' permission e.g. patrons using the OPAC. - When an ILL request without a manager has its status changed, the staff member making the change is automatically assigned as its manager e.g. by clicking 'confirm' or 'revert request'. - It is possible to manually update a request's manager by clicking the 'Edit request' toolbar button when viewing a request. The patron search modal, 'select manager' button and all its functionality is shared with the 'select manager' present in the suggestions module. This means that when editing an ILL request, the 'managedby' defaults to the staff member editing the request, unless 'Keep existing manager' is clicked, like it happens in suggestions. - This is fully core built, all backends will automatically hook into this functionality, because: -- Automatic 'managedby' happen on status change, regardless of backend -- All requests have access to 'edit request' page, regardless of backend - Only if a logged in staff member exists does the auto set manager. If no staff member is found, nothing happens e.g. an ILL request status was changed by a CLI command / cronjob -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #9 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187914&action=edit Bug 40504: atomicupdate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187915&action=edit Bug 40504: Add tests Test plan, ktd, apply patches: 1) Enable ILLModule 2) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Set a 'type', add a cardnumber e.g. '23529000035676', and a library. Click 'Submit'. 4) Notice the new 'Managed by' field entry on the 'Manage request' page. This should be assigned to your logged in user. 5) Click 'Edit request' from the top toolbar 6) Notice the new 'Managed by' form entry. Click 'Select manager' and click 'Search'. Only the 'koha' user should be returned. 7) Notice the message at the top 'Only staff with superlibrarian or ILL permissions are returned in the search results'. 8) Let's give 'ill' permissions to Edna Acosta, visit: <staff_url>/cgi-bin/koha/members/member-flags.pl?member=5 9) Search for 'ill' permission (Search for 'interlibrary' on the top right search bar) and set 'ill' permission to Edna Acosta. Save. 10) Repeat 6). Notice that now when you use the patron search modal Edna Acosta is also returned. Select Edna. Click 'Submit' to edit the request. 11) Edit again. Notice the 'Managed by' is showing 'You', with the message 'Previously was Edna Acosta'. This is the desired behavior mimicked from Suggestions i.e. the staff member that is editing the request details is assumed to becomes it's manager by default. The staff member must click 'Keep existing manager' if they want to submit changes without changing the request's manager. Test buttons, save, verify that it all works. 12) Visit the ILL list table: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 13) Click 'columns' and pick 'Managed by'. Notice it shows correctly with the link to the patron and sorting also works. 14) Create a new user without permissions (OPAC only user) 15) Access the OPAC ILL and login as that user (preferably on a different browser session as we'll want to access the staff UI as staff member again), visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 16) Pick a type and click 'Create' 17) Repeat 12) Notice the newly created request from OPAC is 'Managed by': Nobody. This is intentional as that request still needs to be assigned to a staff member. Suggestions testing: 1) This testing is also important as the existing suggestions 'Managed by' functionality has been abstracted to be utilized by both the suggestions and ILL module. 2) Access suggestions, visit: <staff_url>/cgi-bin/koha/suggestion/suggestion.pl 3) Click 'New purchase suggestion'. Notice the select manager button is also there. Click it and click 'search'. On the modal, the following message should show 'Only staff with superlibrarian or full suggestions permissions are returned in the search results' and the patrons shown should reflect that. 4) Do the same exercises here as we just did for the ILL module, i.e. create a staff member with permission 'suggestions.suggestions_manage' and ensure that shows on the modal, assign that patron as manager, edit again, verify that it defaults to 'You' and that the 'Keep existing manager' button works as before. 5) Finally, test the suggestions list table, repeat 2) and notice the 'Update manager' action at the bottom, test that that works just as well, by checking a few suggestions boxes, selecting a manager to your selection and clicking the 'Submit' button under it. Run tests: prove t/db_dependent/Koha/ILL/Request.t prove t/db_dependent/api/v1/ill_users.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@openfifth.co.uk | |, | |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187914|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188365&action=edit Bug 40504: atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187915|0 |1 is obsolete| | --- Comment #12 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 188563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188563&action=edit Bug 40504: Add tests Test plan, ktd, apply patches: 1) Enable ILLModule 2) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Set a 'type', add a cardnumber e.g. '23529000035676', and a library. Click 'Submit'. 4) Notice the new 'Managed by' field entry on the 'Manage request' page. This should be assigned to your logged in user. 5) Click 'Edit request' from the top toolbar 6) Notice the new 'Managed by' form entry. Click 'Select manager' and click 'Search'. Only the 'koha' user should be returned. 7) Notice the message at the top 'Only staff with superlibrarian or ILL permissions are returned in the search results'. 8) Let's give 'ill' permissions to Edna Acosta, visit: <staff_url>/cgi-bin/koha/members/member-flags.pl?member=5 9) Search for 'ill' permission (Search for 'interlibrary' on the top right search bar) and set 'ill' permission to Edna Acosta. Save. 10) Repeat 6). Notice that now when you use the patron search modal Edna Acosta is also returned. Select Edna. Click 'Submit' to edit the request. 11) Edit again. Notice the 'Managed by' is showing 'You', with the message 'Previously was Edna Acosta'. This is the desired behavior mimicked from Suggestions i.e. the staff member that is editing the request details is assumed to becomes it's manager by default. The staff member must click 'Keep existing manager' if they want to submit changes without changing the request's manager. Test buttons, save, verify that it all works. 12) Visit the ILL list table: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 13) Click 'columns' and pick 'Managed by'. Notice it shows correctly with the link to the patron and sorting also works. 14) Create a new user without permissions (OPAC only user) 15) Access the OPAC ILL and login as that user (preferably on a different browser session as we'll want to access the staff UI as staff member again), visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 16) Pick a type and click 'Create' 17) Repeat 12) Notice the newly created request from OPAC is 'Managed by': Nobody. This is intentional as that request still needs to be assigned to a staff member. Suggestions testing: 1) This testing is also important as the existing suggestions 'Managed by' functionality has been abstracted to be utilized by both the suggestions and ILL module. 2) Access suggestions, visit: <staff_url>/cgi-bin/koha/suggestion/suggestion.pl 3) Click 'New purchase suggestion'. Notice the select manager button is also there. Click it and click 'search'. On the modal, the following message should show 'Only staff with superlibrarian or full suggestions permissions are returned in the search results' and the patrons shown should reflect that. 4) Do the same exercises here as we just did for the ILL module, i.e. create a staff member with permission 'suggestions.suggestions_manage' and ensure that shows on the modal, assign that patron as manager, edit again, verify that it defaults to 'You' and that the 'Keep existing manager' button works as before. 5) Finally, test the suggestions list table, repeat 2) and notice the 'Update manager' action at the bottom, test that that works just as well, by checking a few suggestions boxes, selecting a manager to your selection and clicking the 'Submit' button under it. Run tests: prove t/db_dependent/Koha/ILL/Request.t prove t/db_dependent/api/v1/ill_users.t Signed-off-by: Pedro <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #13 from Jeremy Evans <jeremy.evans@ukhsa.gov.uk> --- I have tested this on a sandbox and it is working as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188563|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187915|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187906|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188565&action=edit Bug 40504: Preparation: Abstract 'managed by' functionality from suggestions Move 'managed by' and 'restore previous manager' form and show functionality to reusable .inc files Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187907|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188566&action=edit Bug 40504: Preparation: Add empty_table_settings option to patron_search_js This is required for ILL 'select manager' functionality, as table_settings are already defined there and the user modal table will pick that up unless explicitly stated to not use it, thus empty_table_settings Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187908|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188567&action=edit Bug 40504: Preparation: Disambiguation of .clear_search This is required, or clicking 'Clear' on the ILL patron search modal will trigger this event listener and cause a JS error, as the 'regular' ILL table is not shown/initialized when editing an ILL request Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187909|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188568&action=edit Bug 40504: Add ill/users API endpoint Required to get users filtered by 'ill' permission for patron search modal prove t/db_dependent/api/v1/ill_users.t Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187910|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188569&action=edit Bug 40504: dbic Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187911|0 |1 is obsolete| | --- Comment #19 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188570&action=edit Bug 40504: Add 'managedby' to illrequests This also includes a 'manager' accessor which returns the Koha::Patron object Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187912|0 |1 is obsolete| | --- Comment #20 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188571&action=edit Bug 40504: UI improvements This turns the 'Select manager' and 'Restore manager' actions to proper buttons, well aligned in where they are displayed. The 'Select manager' functionality in the suggestions table page is also updated to make use of the same reusable button block Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187913|0 |1 is obsolete| | --- Comment #21 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188572&action=edit Bug 40504: Auto functionality: - The staff member who creates a new ILL request is automatically assigned as its manager. - No manager is assigned to ILL requests made by users without 'ill' permission e.g. patrons using the OPAC. - When an ILL request without a manager has its status changed, the staff member making the change is automatically assigned as its manager e.g. by clicking 'confirm' or 'revert request'. - It is possible to manually update a request's manager by clicking the 'Edit request' toolbar button when viewing a request. The patron search modal, 'select manager' button and all its functionality is shared with the 'select manager' present in the suggestions module. This means that when editing an ILL request, the 'managedby' defaults to the staff member editing the request, unless 'Keep existing manager' is clicked, like it happens in suggestions. - This is fully core built, all backends will automatically hook into this functionality, because: -- Automatic 'managedby' happen on status change, regardless of backend -- All requests have access to 'edit request' page, regardless of backend - Only if a logged in staff member exists does the auto set manager. If no staff member is found, nothing happens e.g. an ILL request status was changed by a CLI command / cronjob Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187915|0 |1 is obsolete| | --- Comment #22 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188573&action=edit Bug 40504: Add tests Test plan, ktd, apply patches: 1) Enable ILLModule 2) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Set a 'type', add a cardnumber e.g. '23529000035676', and a library. Click 'Submit'. 4) Notice the new 'Managed by' field entry on the 'Manage request' page. This should be assigned to your logged in user. 5) Click 'Edit request' from the top toolbar 6) Notice the new 'Managed by' form entry. Click 'Select manager' and click 'Search'. Only the 'koha' user should be returned. 7) Notice the message at the top 'Only staff with superlibrarian or ILL permissions are returned in the search results'. 8) Let's give 'ill' permissions to Edna Acosta, visit: <staff_url>/cgi-bin/koha/members/member-flags.pl?member=5 9) Search for 'ill' permission (Search for 'interlibrary' on the top right search bar) and set 'ill' permission to Edna Acosta. Save. 10) Repeat 6). Notice that now when you use the patron search modal Edna Acosta is also returned. Select Edna. Click 'Submit' to edit the request. 11) Edit again. Notice the 'Managed by' is showing 'You', with the message 'Previously was Edna Acosta'. This is the desired behavior mimicked from Suggestions i.e. the staff member that is editing the request details is assumed to becomes it's manager by default. The staff member must click 'Keep existing manager' if they want to submit changes without changing the request's manager. Test buttons, save, verify that it all works. 12) Visit the ILL list table: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 13) Click 'columns' and pick 'Managed by'. Notice it shows correctly with the link to the patron and sorting also works. 14) Create a new user without permissions (OPAC only user) 15) Access the OPAC ILL and login as that user (preferably on a different browser session as we'll want to access the staff UI as staff member again), visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 16) Pick a type and click 'Create' 17) Repeat 12) Notice the newly created request from OPAC is 'Managed by': Nobody. This is intentional as that request still needs to be assigned to a staff member. Suggestions testing: 1) This testing is also important as the existing suggestions 'Managed by' functionality has been abstracted to be utilized by both the suggestions and ILL module. 2) Access suggestions, visit: <staff_url>/cgi-bin/koha/suggestion/suggestion.pl 3) Click 'New purchase suggestion'. Notice the select manager button is also there. Click it and click 'search'. On the modal, the following message should show 'Only staff with superlibrarian or full suggestions permissions are returned in the search results' and the patrons shown should reflect that. 4) Do the same exercises here as we just did for the ILL module, i.e. create a staff member with permission 'suggestions.suggestions_manage' and ensure that shows on the modal, assign that patron as manager, edit again, verify that it defaults to 'You' and that the 'Keep existing manager' button works as before. 5) Finally, test the suggestions list table, repeat 2) and notice the 'Update manager' action at the bottom, test that that works just as well, by checking a few suggestions boxes, selecting a manager to your selection and clicking the 'Submit' button under it. Run tests: prove t/db_dependent/Koha/ILL/Request.t prove t/db_dependent/api/v1/ill_users.t Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188365|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188574&action=edit Bug 40504: atomicupdate Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #24 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188624&action=edit Bug 40504: (QA follow-up): Add 'managed by' filter This adds a 'Managed by:' filter input on the left side filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188624|0 |1 is obsolete| | --- Comment #25 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188625&action=edit Bug 40504: (QA follow-up): Add 'managed by' filter This adds a 'Managed by:' filter input on the left side filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188625|0 |1 is obsolete| | --- Comment #26 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188935&action=edit Bug 40504: (QA follow-up): Add 'managed by' filter This adds a 'Managed by:' filter input on the left side filters. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188569|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #27 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188936&action=edit Bug 40504: [DONT PUSH] dbic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188565|0 |1 is obsolete| | --- Comment #28 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191196&action=edit Bug 40504: Preparation: Abstract 'managed by' functionality from suggestions Move 'managed by' and 'restore previous manager' form and show functionality to reusable .inc files Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188566|0 |1 is obsolete| | --- Comment #29 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191197&action=edit Bug 40504: Preparation: Add empty_table_settings option to patron_search_js This is required for ILL 'select manager' functionality, as table_settings are already defined there and the user modal table will pick that up unless explicitly stated to not use it, thus empty_table_settings Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188567|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191198&action=edit Bug 40504: Preparation: Disambiguation of .clear_search This is required, or clicking 'Clear' on the ILL patron search modal will trigger this event listener and cause a JS error, as the 'regular' ILL table is not shown/initialized when editing an ILL request Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188568|0 |1 is obsolete| | --- Comment #31 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191199&action=edit Bug 40504: Add ill/users API endpoint Required to get users filtered by 'ill' permission for patron search modal prove t/db_dependent/api/v1/ill_users.t Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188570|0 |1 is obsolete| | --- Comment #32 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191200&action=edit Bug 40504: Add 'managedby' to illrequests This also includes a 'manager' accessor which returns the Koha::Patron object Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188571|0 |1 is obsolete| | --- Comment #33 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191201&action=edit Bug 40504: UI improvements This turns the 'Select manager' and 'Restore manager' actions to proper buttons, well aligned in where they are displayed. The 'Select manager' functionality in the suggestions table page is also updated to make use of the same reusable button block Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188572|0 |1 is obsolete| | --- Comment #34 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191202&action=edit Bug 40504: Auto functionality: - The staff member who creates a new ILL request is automatically assigned as its manager. - No manager is assigned to ILL requests made by users without 'ill' permission e.g. patrons using the OPAC. - When an ILL request without a manager has its status changed, the staff member making the change is automatically assigned as its manager e.g. by clicking 'confirm' or 'revert request'. - It is possible to manually update a request's manager by clicking the 'Edit request' toolbar button when viewing a request. The patron search modal, 'select manager' button and all its functionality is shared with the 'select manager' present in the suggestions module. This means that when editing an ILL request, the 'managedby' defaults to the staff member editing the request, unless 'Keep existing manager' is clicked, like it happens in suggestions. - This is fully core built, all backends will automatically hook into this functionality, because: -- Automatic 'managedby' happen on status change, regardless of backend -- All requests have access to 'edit request' page, regardless of backend - Only if a logged in staff member exists does the auto set manager. If no staff member is found, nothing happens e.g. an ILL request status was changed by a CLI command / cronjob Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188573|0 |1 is obsolete| | --- Comment #35 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191203&action=edit Bug 40504: Add tests Test plan, ktd, apply patches: 1) Enable ILLModule 2) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Set a 'type', add a cardnumber e.g. '23529000035676', and a library. Click 'Submit'. 4) Notice the new 'Managed by' field entry on the 'Manage request' page. This should be assigned to your logged in user. 5) Click 'Edit request' from the top toolbar 6) Notice the new 'Managed by' form entry. Click 'Select manager' and click 'Search'. Only the 'koha' user should be returned. 7) Notice the message at the top 'Only staff with superlibrarian or ILL permissions are returned in the search results'. 8) Let's give 'ill' permissions to Edna Acosta, visit: <staff_url>/cgi-bin/koha/members/member-flags.pl?member=5 9) Search for 'ill' permission (Search for 'interlibrary' on the top right search bar) and set 'ill' permission to Edna Acosta. Save. 10) Repeat 6). Notice that now when you use the patron search modal Edna Acosta is also returned. Select Edna. Click 'Submit' to edit the request. 11) Edit again. Notice the 'Managed by' is showing 'You', with the message 'Previously was Edna Acosta'. This is the desired behavior mimicked from Suggestions i.e. the staff member that is editing the request details is assumed to becomes it's manager by default. The staff member must click 'Keep existing manager' if they want to submit changes without changing the request's manager. Test buttons, save, verify that it all works. 12) Visit the ILL list table: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 13) Click 'columns' and pick 'Managed by'. Notice it shows correctly with the link to the patron and sorting also works. 14) Create a new user without permissions (OPAC only user) 15) Access the OPAC ILL and login as that user (preferably on a different browser session as we'll want to access the staff UI as staff member again), visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 16) Pick a type and click 'Create' 17) Repeat 12) Notice the newly created request from OPAC is 'Managed by': Nobody. This is intentional as that request still needs to be assigned to a staff member. Suggestions testing: 1) This testing is also important as the existing suggestions 'Managed by' functionality has been abstracted to be utilized by both the suggestions and ILL module. 2) Access suggestions, visit: <staff_url>/cgi-bin/koha/suggestion/suggestion.pl 3) Click 'New purchase suggestion'. Notice the select manager button is also there. Click it and click 'search'. On the modal, the following message should show 'Only staff with superlibrarian or full suggestions permissions are returned in the search results' and the patrons shown should reflect that. 4) Do the same exercises here as we just did for the ILL module, i.e. create a staff member with permission 'suggestions.suggestions_manage' and ensure that shows on the modal, assign that patron as manager, edit again, verify that it defaults to 'You' and that the 'Keep existing manager' button works as before. 5) Finally, test the suggestions list table, repeat 2) and notice the 'Update manager' action at the bottom, test that that works just as well, by checking a few suggestions boxes, selecting a manager to your selection and clicking the 'Submit' button under it. Run tests: prove t/db_dependent/Koha/ILL/Request.t prove t/db_dependent/api/v1/ill_users.t Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188574|0 |1 is obsolete| | --- Comment #36 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191204&action=edit Bug 40504: atomicupdate Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188935|0 |1 is obsolete| | --- Comment #37 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191205&action=edit Bug 40504: (QA follow-up): Add 'managed by' filter This adds a 'Managed by:' filter input on the left side filters. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188936|0 |1 is obsolete| | --- Comment #38 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 191206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191206&action=edit Bug 40504: [DONT PUSH] dbic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #39 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 192094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192094&action=edit Bug 40504: (QA follow-up): Prevent exiting without considering managed_by -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Lisette Scheer <lisette@bywatersolutions.com> --- Suggestions doesn't work as expected. This doesn't happen: Notice the 'Managed by' is showing 'You', with the message 'Previously was Edna Acosta'. This is the desired behavior mimicked from Suggestions i.e. the staff member that is editing the request details is assumed to becomes it's manager by default. The staff member must click 'Keep existing manager' if they want to submit changes without changing the request's manager. Test buttons, save, verify that it all works. Also the table shows last modification by as the same as the manager even if was, for example, koha making edna the manager. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #41 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Needs a rebase, no longer applies after bug 39721, possibly others. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191196|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193186&action=edit Bug 40504: Preparation: Abstract 'managed by' functionality from suggestions Move 'managed by' and 'restore previous manager' form and show functionality to reusable .inc files Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191197|0 |1 is obsolete| | --- Comment #43 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193187&action=edit Bug 40504: Preparation: Add empty_table_settings option to patron_search_js This is required for ILL 'select manager' functionality, as table_settings are already defined there and the user modal table will pick that up unless explicitly stated to not use it, thus empty_table_settings Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191198|0 |1 is obsolete| | --- Comment #44 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193188&action=edit Bug 40504: Preparation: Disambiguation of .clear_search This is required, or clicking 'Clear' on the ILL patron search modal will trigger this event listener and cause a JS error, as the 'regular' ILL table is not shown/initialized when editing an ILL request Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191199|0 |1 is obsolete| | --- Comment #45 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193189&action=edit Bug 40504: Add ill/users API endpoint Required to get users filtered by 'ill' permission for patron search modal prove t/db_dependent/api/v1/ill_users.t Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191200|0 |1 is obsolete| | --- Comment #46 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193190&action=edit Bug 40504: Add 'managedby' to illrequests This also includes a 'manager' accessor which returns the Koha::Patron object Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191201|0 |1 is obsolete| | --- Comment #47 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193191&action=edit Bug 40504: UI improvements This turns the 'Select manager' and 'Restore manager' actions to proper buttons, well aligned in where they are displayed. The 'Select manager' functionality in the suggestions table page is also updated to make use of the same reusable button block Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191202|0 |1 is obsolete| | --- Comment #48 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193192&action=edit Bug 40504: Auto functionality: - The staff member who creates a new ILL request is automatically assigned as its manager. - No manager is assigned to ILL requests made by users without 'ill' permission e.g. patrons using the OPAC. - When an ILL request without a manager has its status changed, the staff member making the change is automatically assigned as its manager e.g. by clicking 'confirm' or 'revert request'. - It is possible to manually update a request's manager by clicking the 'Edit request' toolbar button when viewing a request. The patron search modal, 'select manager' button and all its functionality is shared with the 'select manager' present in the suggestions module. This means that when editing an ILL request, the 'managedby' defaults to the staff member editing the request, unless 'Keep existing manager' is clicked, like it happens in suggestions. - This is fully core built, all backends will automatically hook into this functionality, because: -- Automatic 'managedby' happen on status change, regardless of backend -- All requests have access to 'edit request' page, regardless of backend - Only if a logged in staff member exists does the auto set manager. If no staff member is found, nothing happens e.g. an ILL request status was changed by a CLI command / cronjob Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191203|0 |1 is obsolete| | --- Comment #49 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193193&action=edit Bug 40504: Add tests Test plan, ktd, apply patches: 1) Enable ILLModule 2) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Set a 'type', add a cardnumber e.g. '23529000035676', and a library. Click 'Submit'. 4) Notice the new 'Managed by' field entry on the 'Manage request' page. This should be assigned to your logged in user. 5) Click 'Edit request' from the top toolbar 6) Notice the new 'Managed by' form entry. Click 'Select manager' and click 'Search'. Only the 'koha' user should be returned. 7) Notice the message at the top 'Only staff with superlibrarian or ILL permissions are returned in the search results'. 8) Let's give 'ill' permissions to Edna Acosta, visit: <staff_url>/cgi-bin/koha/members/member-flags.pl?member=5 9) Search for 'ill' permission (Search for 'interlibrary' on the top right search bar) and set 'ill' permission to Edna Acosta. Save. 10) Repeat 6). Notice that now when you use the patron search modal Edna Acosta is also returned. Select Edna. Click 'Submit' to edit the request. 11) Edit again. Notice the 'Managed by' is showing 'You', with the message 'Previously was Edna Acosta'. This is the desired behavior mimicked from Suggestions i.e. the staff member that is editing the request details is assumed to becomes it's manager by default. The staff member must click 'Keep existing manager' if they want to submit changes without changing the request's manager. Test buttons, save, verify that it all works. 12) Visit the ILL list table: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 13) Click 'columns' and pick 'Managed by'. Notice it shows correctly with the link to the patron and sorting also works. 14) Create a new user without permissions (OPAC only user) 15) Access the OPAC ILL and login as that user (preferably on a different browser session as we'll want to access the staff UI as staff member again), visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 16) Pick a type and click 'Create' 17) Repeat 12) Notice the newly created request from OPAC is 'Managed by': Nobody. This is intentional as that request still needs to be assigned to a staff member. Suggestions testing: 1) This testing is also important as the existing suggestions 'Managed by' functionality has been abstracted to be utilized by both the suggestions and ILL module. 2) Access suggestions, visit: <staff_url>/cgi-bin/koha/suggestion/suggestion.pl 3) Click 'New purchase suggestion'. Notice the select manager button is also there. Click it and click 'search'. On the modal, the following message should show 'Only staff with superlibrarian or full suggestions permissions are returned in the search results' and the patrons shown should reflect that. 4) Do the same exercises here as we just did for the ILL module, i.e. create a staff member with permission 'suggestions.suggestions_manage' and ensure that shows on the modal, assign that patron as manager, edit again, verify that it defaults to 'You' and that the 'Keep existing manager' button works as before. 5) Finally, test the suggestions list table, repeat 2) and notice the 'Update manager' action at the bottom, test that that works just as well, by checking a few suggestions boxes, selecting a manager to your selection and clicking the 'Submit' button under it. Run tests: prove t/db_dependent/Koha/ILL/Request.t prove t/db_dependent/api/v1/ill_users.t Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191204|0 |1 is obsolete| | --- Comment #50 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193194&action=edit Bug 40504: atomicupdate Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191205|0 |1 is obsolete| | --- Comment #51 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193195&action=edit Bug 40504: (QA follow-up): Add 'managed by' filter This adds a 'Managed by:' filter input on the left side filters. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191206|0 |1 is obsolete| | --- Comment #52 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193196&action=edit Bug 40504: [DONT PUSH] dbic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192094|0 |1 is obsolete| | --- Comment #53 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193197&action=edit Bug 40504: (QA follow-up): Prevent exiting without considering managed_by -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #54 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Lisette Scheer from comment #40)
Suggestions doesn't work as expected. This doesn't happen: Notice the 'Managed by' is showing 'You', with the message 'Previously was Edna Acosta'. This is the desired behavior mimicked from Suggestions i.e. the staff member that is editing the request details is assumed to becomes it's manager by default. The staff member must click 'Keep existing manager' if they want to submit changes without changing the request's manager. Test buttons, save, verify that it all works.
Hi Lisette, thank you for looking here. I had to rebase on bug 39721 and bug 33544 plus filed a fix that I believe is caused by bug 39721 (bug 41857) and only then I was able to follow the test plan here. I followed the test plan again (after the above) and I can't find anything wrong in suggestions as you mentioned, can you please test again or please clarify exactly what's wrong.
Also the table shows last modification by as the same as the manager even if was, for example, koha making edna the manager.
I believe this is beyond the scope of this patchset as Koha::Suggestion->last_modifier is just returning self->_result->managedby i.e. exactly the same as Koha::Suggestion->manager i.e. the table showing the same patron for both columns appears to be working as intended but even if not, it's not something introduced in this patchset. Happy to be proven wrong and follow-up if so of course. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #55 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194023&action=edit Bug 40504: Preparation: Abstract 'managed by' functionality from suggestions Move 'managed by' and 'restore previous manager' form and show functionality to reusable .inc files Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #56 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194024&action=edit Bug 40504: Preparation: Add empty_table_settings option to patron_search_js This is required for ILL 'select manager' functionality, as table_settings are already defined there and the user modal table will pick that up unless explicitly stated to not use it, thus empty_table_settings Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #57 from Lisette Scheer <lisette@bywatersolutions.com> --- I added a qa follow-up for fixing process blocks getting incorrectly prettifed to an untranslatable format. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193187|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193191|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193192|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193193|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193194|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193195|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194023|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194024|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #58 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194026&action=edit Bug 40504: Preparation: Abstract 'managed by' functionality from suggestions Move 'managed by' and 'restore previous manager' form and show functionality to reusable .inc files Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #59 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194027&action=edit Bug 40504: Preparation: Add empty_table_settings option to patron_search_js This is required for ILL 'select manager' functionality, as table_settings are already defined there and the user modal table will pick that up unless explicitly stated to not use it, thus empty_table_settings Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #60 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194028&action=edit Bug 40504: Preparation: Disambiguation of .clear_search This is required, or clicking 'Clear' on the ILL patron search modal will trigger this event listener and cause a JS error, as the 'regular' ILL table is not shown/initialized when editing an ILL request Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #61 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194029&action=edit Bug 40504: Add ill/users API endpoint Required to get users filtered by 'ill' permission for patron search modal prove t/db_dependent/api/v1/ill_users.t Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #62 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194030&action=edit Bug 40504: Add 'managedby' to illrequests This also includes a 'manager' accessor which returns the Koha::Patron object Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #63 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194031&action=edit Bug 40504: UI improvements This turns the 'Select manager' and 'Restore manager' actions to proper buttons, well aligned in where they are displayed. The 'Select manager' functionality in the suggestions table page is also updated to make use of the same reusable button block Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #64 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194032&action=edit Bug 40504: Auto functionality: - The staff member who creates a new ILL request is automatically assigned as its manager. - No manager is assigned to ILL requests made by users without 'ill' permission e.g. patrons using the OPAC. - When an ILL request without a manager has its status changed, the staff member making the change is automatically assigned as its manager e.g. by clicking 'confirm' or 'revert request'. - It is possible to manually update a request's manager by clicking the 'Edit request' toolbar button when viewing a request. The patron search modal, 'select manager' button and all its functionality is shared with the 'select manager' present in the suggestions module. This means that when editing an ILL request, the 'managedby' defaults to the staff member editing the request, unless 'Keep existing manager' is clicked, like it happens in suggestions. - This is fully core built, all backends will automatically hook into this functionality, because: -- Automatic 'managedby' happen on status change, regardless of backend -- All requests have access to 'edit request' page, regardless of backend - Only if a logged in staff member exists does the auto set manager. If no staff member is found, nothing happens e.g. an ILL request status was changed by a CLI command / cronjob Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #65 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194033&action=edit Bug 40504: Add tests Test plan, ktd, apply patches: 1) Enable ILLModule 2) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Set a 'type', add a cardnumber e.g. '23529000035676', and a library. Click 'Submit'. 4) Notice the new 'Managed by' field entry on the 'Manage request' page. This should be assigned to your logged in user. 5) Click 'Edit request' from the top toolbar 6) Notice the new 'Managed by' form entry. Click 'Select manager' and click 'Search'. Only the 'koha' user should be returned. 7) Notice the message at the top 'Only staff with superlibrarian or ILL permissions are returned in the search results'. 8) Let's give 'ill' permissions to Edna Acosta, visit: <staff_url>/cgi-bin/koha/members/member-flags.pl?member=5 9) Search for 'ill' permission (Search for 'interlibrary' on the top right search bar) and set 'ill' permission to Edna Acosta. Save. 10) Repeat 6). Notice that now when you use the patron search modal Edna Acosta is also returned. Select Edna. Click 'Submit' to edit the request. 11) Edit again. Notice the 'Managed by' is showing 'You', with the message 'Previously was Edna Acosta'. This is the desired behavior mimicked from Suggestions i.e. the staff member that is editing the request details is assumed to becomes it's manager by default. The staff member must click 'Keep existing manager' if they want to submit changes without changing the request's manager. Test buttons, save, verify that it all works. 12) Visit the ILL list table: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 13) Click 'columns' and pick 'Managed by'. Notice it shows correctly with the link to the patron and sorting also works. 14) Create a new user without permissions (OPAC only user) 15) Access the OPAC ILL and login as that user (preferably on a different browser session as we'll want to access the staff UI as staff member again), visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 16) Pick a type and click 'Create' 17) Repeat 12) Notice the newly created request from OPAC is 'Managed by': Nobody. This is intentional as that request still needs to be assigned to a staff member. Suggestions testing: 1) This testing is also important as the existing suggestions 'Managed by' functionality has been abstracted to be utilized by both the suggestions and ILL module. 2) Access suggestions, visit: <staff_url>/cgi-bin/koha/suggestion/suggestion.pl 3) Click 'New purchase suggestion'. Notice the select manager button is also there. Click it and click 'search'. On the modal, the following message should show 'Only staff with superlibrarian or full suggestions permissions are returned in the search results' and the patrons shown should reflect that. 4) Do the same exercises here as we just did for the ILL module, i.e. create a staff member with permission 'suggestions.suggestions_manage' and ensure that shows on the modal, assign that patron as manager, edit again, verify that it defaults to 'You' and that the 'Keep existing manager' button works as before. 5) Finally, test the suggestions list table, repeat 2) and notice the 'Update manager' action at the bottom, test that that works just as well, by checking a few suggestions boxes, selecting a manager to your selection and clicking the 'Submit' button under it. Run tests: prove t/db_dependent/Koha/ILL/Request.t prove t/db_dependent/api/v1/ill_users.t Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #66 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194034&action=edit Bug 40504: atomicupdate Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #67 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194035&action=edit Bug 40504: (QA follow-up): Add 'managed by' filter This adds a 'Managed by:' filter input on the left side filters. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #68 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194036&action=edit Bug 40504: [DONT PUSH] dbic Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #69 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194037&action=edit Bug 40504: (QA follow-up): Prevent exiting without considering managed_by Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #70 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 194038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194038&action=edit Bug 40504: (QA follow-up): Add prettier-ignore to process blocks Patch from commit d560f94 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #71 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Lisette Scheer from comment #57)
I added a qa follow-up for fixing process blocks getting incorrectly prettifed to an untranslatable format.
Thank you, Lisette. This patch is breaking functionality on the ILL side. Apply all patches, you'll notice you can't select manager for an ILL request. Revert last patch. Notice you can. Doing a 'git show -w <commit_hash>' for this patch shows markup changes that I don't think are intentional i.e. more than just prettier changes. Please rectify or make absolete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #72 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194332&action=edit Bug 40504: Fix DB structure comparison Fix misc4dev/run_tests.pl --run-db-compare-only -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |"Managed by" feature for | |Interlibrary Loan (ILL) | |requests, mirroring | |existing functionality in | |purchase suggestions. This | |is particularly beneficial | |for large consortia | |managing high volumes of | |requests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194038|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42071 Status|Signed Off |Failed QA --- Comment #73 from Lisette Scheer <lisette@bywatersolutions.com> --- I was able to tidy sucessfully this time without it reverting. However when I save a manager in the ILL module, it doesn't save them, just loads it back up with Manager:Nobody Whatever oddness was happening with suggestions is resolved now. I did add a dependancy because suggestions don't load a single suggestion anymore. Bug 42071 fixes this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42071 [Bug 42071] Suggestion does not load when viewing the suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #74 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 195142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195142&action=edit Bug 40504: (QA follow-up) Tidy Patch from commit 73a86d3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #75 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Lisette Scheer from comment #73)
I was able to tidy sucessfully this time without it reverting. However when I save a manager in the ILL module, it doesn't save them, just loads it back up with Manager:Nobody
I believe this is a regression added by the tidy patch: - [% PROCESS select_manager_form - manager => request.manager - required_permission => CAN_user_ill - %] + [% PROCESS select_manager_form manager => request.manager equired_permission => CAN_user_ill %] Notice 'equired_permission'. I was able to reproduce the issue you described and confirm it appears it's caused by this change. Are you able to revisit the tidy patch or re-test without it? Thank you.
I did add a dependancy because suggestions don't load a single suggestion anymore. Bug 42071 fixes this.
Thank you for bug 42071. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195142|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #76 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 195200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195200&action=edit Bug 40504: (QA follow-up) Tidy Patch from commit 007403a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #77 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Lisette Scheer from comment #76)
Created attachment 195200 [details] [review] Bug 40504: (QA follow-up) Tidy
Patch from commit 007403a
Oddly it was fixed on my local already, works great and I uploaded the patch. I'd love if it recorded a log entry, but there's also some problems with ILL logging already, so I think that should be separate. Bug 31520 - Only log ILL changes that are actual changes Bug 40681 - Record diff in action logs when modifying an ILL request Bug 40889 - ILL logging doesn't log all changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 --- Comment #78 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #79 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504 Bug 40504 depends on bug 42071, which changed state. Bug 42071 Summary: Suggestion does not load when viewing the suggestion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42071 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org