[Bug 34558] New: Update custom.sql for it-IT webinstaller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Bug ID: 34558 Summary: Update custom.sql for it-IT webinstaller Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: ztajoli@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com With new developments about transaltion, the file ../installer/data/mysql/localization/it-IT/custom.sql needs an update. Today, when you install a 23.05 version with Italian setup (it-IT), you will see a warning about problems with Authorised values (AV). We need to fix it and update the file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli <ztajoli@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |ztajoli@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli <ztajoli@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ztajoli@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli <ztajoli@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gmcharlt@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 --- Comment #1 from Zeno Tajoli <ztajoli@gmail.com> --- Created attachment 154507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154507&action=edit Image of the bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 --- Comment #2 from Zeno Tajoli <ztajoli@gmail.com> --- Created attachment 154551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154551&action=edit patch for custom.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli <ztajoli@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Zeno Tajoli <ztajoli@gmail.com> --- It is an update of this file, here there are the specific customization for italian users. Test plan for the patch: Start a web installation with italian language. Select Marc21 as biblio format Select all optional .sql files See the warning present into the image. Conclude the installation. Apply the patch. Drop and recreate the mysql db Redone the installation with italian language. Use the same options written above. Now no more the warning. Installation conclude OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Hi Zeno. I'm not seeing the error. This what I see: ... Dati per la localiozzazione aggiunti * custom.sql L'installazione di base è completa. Nei prossimi passi sarete guidati a fare alcuni punti fondamentali, tra cui l'utente di gestione con tutti i privilegi amministrativi (superlibrarian). Puoi aiutare la comunità di Koha condividendo le tue statistiche con noi. Se vuoi condividere alcuni tuoi dati, attiva la funzionalità nella sezione "Condividi statistiche d'uso" del modulo di amministrazione. ... Here are my testing notes (so far) using koha-testing-docker (KTD) (note that KTD uses MARIA DB in strict mode by default): 1. Install the it-IT language: 1.1 cd misc/translator 1.2 ./translate update it-IT 1.3 ./translate install it-IT 2. Test the web installer: 2.1 Access the database server[1]: mysql -uroot -ppassword -hkoha-db-1 2.2 Drop the koha_kohadev database: drop database koha_kohadev; 2.3 Create the database: create database koha_kohadev; 2.4 Add privileges (for a real installation, this would be limited): grant all on 2.5 koha_kohadev.* to koha_kohadev; 2.6 Restart everything (there may be some errors listed): flush_memcached and then restart_all 2.7 Access the web installer: go to 127.0.0.1:8081 2.8 Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 2.9 Continue through the installation process In addition, your commit message needs to be formatted using these guidelines: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli <ztajoli@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Zeno Tajoli <ztajoli@gmail.com> --- Probably the problem is presnt only on a specific platform. I use Debian 11 with MariaDb (default setup) I change the commit file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to Zeno Tajoli from comment #5)
Probably the problem is presnt only on a specific platform. I use Debian 11 with MariaDb (default setup) I change the commit file
KTD (koha-testing-docker) by default is currently using Debian 11 and MariaDB 10.5.22. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli <ztajoli@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154551|0 |1 is obsolete| | --- Comment #7 from Zeno Tajoli <ztajoli@gmail.com> --- Created attachment 156558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156558&action=edit patch for custom.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli <ztajoli@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Zeno Tajoli <ztajoli@gmail.com> --- I do a new test and now the warning is not present. So in fact is not more a bug fix but only a refactor / update of defaults. I reformat the patch and rewrite test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 156574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156574&action=edit Bug 34558: Update custom.sql for it-IT webinstaller It is an update of this file, here there are the specific customization for italian users. There are simple changes on defaults values. To test it: 1 - Start a web installation with italian language. 2 - Select Marc21 as biblio format 3 - Select all optional .sql files 4 - Conclude the installation. 5 - Go to MySQL command line and do: SELET value FROM systempreferences where variable = 'BorrowersTitles' You see: 'Sig|Sig.ra|Sig.na' 6 - Apply the patch. 7 - Drop and recreate the mysql db 8 - Redone the installation with italian language. 9 - Use the same options written above. 10 - Conclude the installation. 11 - Go to MySQL command line and do: SELET value FROM systempreferences where variable = 'BorrowersTitles' You see: 'Sig|Sig.ra|Dott.|Dott.ssa' 12 - Refactor is OK Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156558|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Comment on attachment 156558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156558 patch for custom.sql Mark the original patch as obsolete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 --- Comment #11 from David Nind <david@davidnind.com> --- Updated testing notes (using koha-testing-docker (KTD)): 1. Install the it-IT language: 1.1 cd misc/translator 1.2 ./translate update it-IT 1.3 ./translate install it-IT 2. Initial run through the web installer: 2.1 Access the database server[1]: mysql -uroot -ppassword -hkoha-db-1 2.2 Drop the koha_kohadev database: drop database koha_kohadev; 2.3 Create the database: create database koha_kohadev; 2.4 Add privileges (for a real installation, this would be limited): grant all on koha_kohadev.* to koha_kohadev; 2.5 Restart everything (there may be some errors listed): flush_memcached and then restart_all 2.6 Access the web installer: go to 127.0.0.1:8081 2.7 Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 2.8 Continue through the installation process 3. As per the test plan (step 5), then apply the patch and repeat 2. 4. Note that the SQL statement for step 5 should be 'SELECT' not 'SELET' in English: SELECT value FROM systempreferences where variable = 'BorrowersTitles' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156574|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156587&action=edit Bug 34558: Update custom.sql for it-IT webinstaller It is an update of this file, here there are the specific customization for italian users. There are simple changes on defaults values. To test it: 1 - Start a web installation with italian language. 2 - Select Marc21 as biblio format 3 - Select all optional .sql files 4 - Conclude the installation. 5 - Go to MySQL command line and do: SELET value FROM systempreferences where variable = 'BorrowersTitles' You see: 'Sig|Sig.ra|Sig.na' 6 - Apply the patch. 7 - Drop and recreate the mysql db 8 - Redone the installation with italian language. 9 - Use the same options written above. 10 - Conclude the installation. 11 - Go to MySQL command line and do: SELECT value FROM systempreferences where variable = 'BorrowersTitles' You see: 'Sig|Sig.ra|Dott.|Dott.ssa' 12 - Refactor is OK Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.11 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org