[Bug 17290] New: Standardize on "Patron categories" when referring to patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Bug ID: 17290 Summary: Standardize on "Patron categories" when referring to patron category Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org See bug 16298 comment#3: git grep -i "patron types"|grep -v translator gives me some occurrences which could be updated as well, don't you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16298 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16298 [Bug 16298] Standardize on "Patron categories" when referring to patron category administration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arouss1980@gmail.com --- Comment #1 from Andreas Roussos <arouss1980@gmail.com> --- I could be wrong, but I think there's a few more occurrences to update if you grep for "patron type" (i.e. in the singular). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Yep, checking singular too is a good idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Gracie <grace.mcky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 --- Comment #3 from Gracie <grace.mcky@gmail.com> --- Created attachment 59119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59119&action=edit Bug 17290 - Standardize on "Patron Categories" We need to standardize on terminology, this changes all instances of patron types to be patron categories. To text, just view the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 59119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59119 Bug 17290 - Standardize on "Patron Categories" Review of attachment 59119: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17290&attachment=59119) ----------------------------------------------------------------- Hey Grace, overall this reads great already - can you please take a look at the notes I made and provide a new patch or a follow-up? Thx! ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ +1,1 @@
+% USE Koha %]
I think this was an accidental change, can you please fix and resubmit? ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/item_circulation_alerts.tt @@ +16,4 @@
<li>To set preferences for all libraries, keep the menu set to 'Default'</li> </ul> </li> + <li>By default all item types and all patrons are notified of check ins and check outs. To change this, click on the item/patron category combination that you would like to stop notices for.</li>
We have patron categories and item types in Koha, so maybe it would read a little better as: item type/patron category ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/members/boraccount.tt @@ +10,4 @@
<ul> <li>Fines will be charged based on your Circulation & Fines Rules</li> + <li>Hold fees will be charged based on the rules you set in the Patron Categories & Categories administration area</li>
I think the original read a little oddly as we don't have a section in administration that reads like the help suggests. My suggestion is to write something like: Hold fees will be charged based on the rules you set for the patron category in administration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Gracie <grace.mcky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Gracie <grace.mcky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59119|0 |1 is obsolete| | --- Comment #5 from Gracie <grace.mcky@gmail.com> --- Created attachment 59176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59176&action=edit Bug 17290 - Standardize on "Patron Categories" We need to standardize on terminology, this changes all instances of patron types to be patron categories. To text, just view the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 59176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59176 Bug 17290 - Standardize on "Patron Categories" Review of attachment 59176: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17290&attachment=59176) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/categorie.tt @@ +2,4 @@
<h1>Patron Categories</h1>
+<p>Patron categories allow you to organize your patrons into different roles, age groups, and patron categories.</p>
Isn't "patron categories." at the end over kill? Patron categories allow you to organize your patrons into different roles, age groups, and categories. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Cédric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59176|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61386&action=edit Bug 17290 - Standardize on "Patron Categories" We need to standardize on terminology, this changes all instances of patron types to be patron categories. To text, just view the patch Signed-off-by: Cédric Vita <cedric.vita@dracenie.com> Signed-off-by: Cédric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61386|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61403&action=edit Bug 17290 - Standardize on "Patron Categories" We need to standardize on terminology, this changes all instances of patron types to be patron categories. To text, just view the patch Signed-off-by: Cédric Vita <cedric.vita@dracenie.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Grace! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #12 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org