[Bug 9471] New: Use DataTables on serials claims page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9471 Bug ID: 9471 Summary: Use DataTables on serials claims page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/claims.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The serials claims page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9471 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9471 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14803&action=edit Bug 9471 - Use DataTables on serials claims page Replace the tablesorter plugin with the DataTables plugin on the serials claims page. This patch replaces some custom table fitlering code with code which uses DataTables' built-in table fitlering. A minor correction to markup has also been made to properly align inputs in the filter form. To test, run the serials claims report for a vendor with data which will populate results. Confirm that table sorting works correctly. Confirm also that filtering by title and branch works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9471 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14803|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 15205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15205&action=edit Signed-off patch Works as advertised. I have compared side by side the both pages, with tablesorter, and with DataTables. The both work. No regression. With DataTables, no more sorting on Begin clam column, which is great. A new sort option may be useful on the Library column (wasn't the with tablesorter neither). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9471 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9471 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5342 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9471 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch Blocks|5342 | QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: All filters and sorts work. It would be great to use the DataTables's filters instead of a "manual" way. I proposed a patch (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8910) in order to use the DT server-side processing for this table, but the first step (Bug 5342) is waiting signoffs for a long time. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9471 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15205|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15227&action=edit Bug 9471 - Use DataTables on serials claims page Replace the tablesorter plugin with the DataTables plugin on the serials claims page. This patch replaces some custom table fitlering code with code which uses DataTables' built-in table fitlering. A minor correction to markup has also been made to properly align inputs in the filter form. To test, run the serials claims report for a vendor with data which will populate results. Confirm that table sorting works correctly. Confirm also that filtering by title and branch works. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as advertised. I have compared side by side the both pages, with tablesorter, and with DataTables. The both work. No regression. With DataTables, no more sorting on Begin clam column, which is great. A new sort option may be usefull on the Library column (wasn't the with tablesorter neither). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9471 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org