[Bug 19165] New: When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Bug ID: 19165 Summary: When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: christophe.croullebois@biblibre.com QA Contact: testopia@bugs.koha-community.org Discounts are not stored in $orderinfo before passing to populate prices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |christophe.croullebois@bibl | |ibre.com Assignee|koha-bugs@lists.koha-commun |christophe.croullebois@bibl |ity.org |ibre.com --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 66380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66380&action=edit Discounts are not stored in $orderinfo before passing to populate prices This patch is the same than Bug 18468, just for 16.11. To test: 1 - Setup a vendor with a discount 2 - Stage a file 3 - Create a basket 4 - Order from staged file 5 - Add a price but no discount 6 - Save order 7 - Note ecost is not discounted 8 - Apply patch 9 - Repeate 2-6 10 - Note ecost is discounted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18468 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Christophe Your patch cannot be successfully applied (see below), could you please fix this up and I will be happy to test again: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19165 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices fatal: sha1 information is lacking or useless (acqui/addorderiso2709.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 19165 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Discounts-are-not-stored-in-orderinfo-before-passi-WXlSlx.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Hi Alex, thx for your attempt, I'll try to rebase it this morning. Best regards. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66380|0 |1 is obsolete| | --- Comment #4 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 67078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67078&action=edit new rebased patch Now it must be ok Alex, thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Sorry Christophe unfortunately it still cannot apply correctly on up to date master branch. Bug 19165 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices 67078 - new rebased patch Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19165 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices fatal: sha1 information is lacking or useless (acqui/addorderiso2709.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 19165 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/new-rebased-patch-iCks9Z.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Hello Alex, ok I understand, in fact this patch is the same than Bug 18468, and in this one people asked to create a new bug report for 16.11.x. I have done that and to test you have to use a branch 16.11.x to apply it not the master. Normally it must be ok on a branch 16.11.x. Thx again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When adding from a staged |[16.11.x] When adding from |file order discounts are |a staged file order |not passed into |discounts are not passed |C4::Acquisitions::populate_ |into |order_with_prices |C4::Acquisitions::populate_ | |order_with_prices CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 --- Comment #7 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67335&action=edit Bug 19165 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices Signed-off-by: Your Name <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault@inlibro.com Attachment #67078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from David Bourgault <david.bourgault@inlibro.com> --- Oops, forgot to change a line in that git alias. Tested working on Koha v16.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Assuming that this is for 16.11.x only? This patch has been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Katrin, should we change the status to Pushed to Stable ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, guess I messed up a bit here. Changing status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org