http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 33446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33446&action=edit Bug 13230: t/Biblio.t should run without a DB This patch makes t/Biblio.t mock the DB connexion setting a void one. All tests in this file currently call the C4::Biblio functions with invalid (absent) parameters, so they are expected to raise warnings and return undef values. If someone writes mocked tests for the rest of the functionality, it is expected to mock the DB calls to match the desired scenario. To test: - Turn of MySQL - Run $ prove t/Biblio.t => FAIL: Tests fail because of missing MySQL server - Apply the patch - Run $ prove t/Biblio.t => SUCCESS: Tests now pass - Start MySQL - Run $ prove t/Biblio.t => SUCCESS: Tests still pass - Sign off Regards Tomas Sponsored-by: The will to procrastinate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33446|0 |1 is obsolete| | --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 33448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33448&action=edit Bug 13230: t/Biblio.t should run without a DB This patch makes t/Biblio.t mock the DB connexion setting a void one. All tests in this file currently call the C4::Biblio functions with invalid (absent) parameters, so they are expected to raise warnings and return undef values. If someone writes mocked tests for the rest of the functionality, it is expected to mock the DB calls to match the desired scenario. To test: - Turn of MySQL - Run $ prove t/Biblio.t => FAIL: Tests fail because of missing MySQL server - Apply the patch - Run $ prove t/Biblio.t => SUCCESS: Tests now pass - Start MySQL - Run $ prove t/Biblio.t => SUCCESS: Tests still pass - Sign off Regards Tomas Sponsored-by: The will to procrastinate Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Sponsored-by: Wanting the darn packages to build -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33448|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 33449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33449&action=edit Bug 13230: t/Biblio.t should run without a DB This patch makes t/Biblio.t mock the DB connexion setting a void one. All tests in this file currently call the C4::Biblio functions with invalid (absent) parameters, so they are expected to raise warnings and return undef values. If someone writes mocked tests for the rest of the functionality, it is expected to mock the DB calls to match the desired scenario. To test: - Turn of MySQL - Run $ prove t/Biblio.t => FAIL: Tests fail because of missing MySQL server - Apply the patch - Run $ prove t/Biblio.t => SUCCESS: Tests now pass - Start MySQL - Run $ prove t/Biblio.t => SUCCESS: Tests still pass - Sign off Regards Tomas Sponsored-by: The will to procrastinate Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Sponsored-by: Wanting the darn packages to build Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33449|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33450&action=edit [PASSED QA] Bug 13230: t/Biblio.t should run without a DB This patch makes t/Biblio.t mock the DB connexion setting a void one. All tests in this file currently call the C4::Biblio functions with invalid (absent) parameters, so they are expected to raise warnings and return undef values. If someone writes mocked tests for the rest of the functionality, it is expected to mock the DB calls to match the desired scenario. To test: - Turn of MySQL - Run $ prove t/Biblio.t => FAIL: Tests fail because of missing MySQL server - Apply the patch - Run $ prove t/Biblio.t => SUCCESS: Tests now pass - Start MySQL - Run $ prove t/Biblio.t => SUCCESS: Tests still pass - Sign off Regards Tomas Sponsored-by: The will to procrastinate Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Sponsored-by: Wanting the darn packages to build Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Sponsored-by: Not wanting to read in my maths book -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12995 -- You are receiving this mail because: You are watching all bug changes.