[Bug 19399] New: Show reports screen should not display query in textarea.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19399 Bug ID: 19399 Summary: Show reports screen should not display query in textarea. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The Guided reports "Show SQL" e.g. https://intranet.bywatersolutions.com/cgi-bin/koha/reports/guided_reports.pl?reports=120&phase=Show%20SQL Looks very similar to the "Edit SQL" screen. https://intranet.bywatersolutions.com/cgi-bin/koha/reports/guided_reports.pl?reports=120&phase=Edit%20SQL Because of the visual similarity, there is a strong temptation to edit the SQL on the Show SQL screen. This is an annoyance; it would be better UX to display the SQL in a <code> tag. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show reports screen should |Show reports screen should |not display query in |not display query in |textarea. |textarea CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19399 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I wonder if this is improved by the switch to CodeMirror for viewing and editing SQL? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19399 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #1)
I wonder if this is improved by the switch to CodeMirror for viewing and editing SQL?
I think it's still valid, if you go to: http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Show%20SQL It does look like the edit screen and you can put your cursor into it, even if you cannot type. Not sure if there is a 'just display' mode for codemirror? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like the modal with the edit button below is probably making this clear enough now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org