[Bug 20061] New: koha-common is not pulling libsearch-elasticsearch-perl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Bug ID: 20061 Summary: koha-common is not pulling libsearch-elasticsearch-perl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: mirko@abunchofthings.net Bug 19542 introduced the harder dependency but failed to add it to PerlDependencies.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |19542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542 [Bug 19542] Koha should display Elasticsearch information in the about page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Mirko Tietgen <mirko@abunchofthings.net> --- I am not sure if this should be a hard dependency - as long as Koha is supposed to work without Elasticsearch - for an enhancement that just displays Elasticsearch infos when Elasticsearch is activated (as far as I understand) Could we tie loading the module to a condition like the SearchEngine syspref setting instead or does that not make sense? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Mirko Tietgen from comment #1)
I am not sure if this should be a hard dependency - as long as Koha is supposed to work without Elasticsearch - for an enhancement that just displays Elasticsearch infos when Elasticsearch is activated (as far as I understand)
Could we tie loading the module to a condition like the SearchEngine syspref setting instead or does that not make sense?
I've always been strongly against having 'Break Koha' option switches. I think the SearchEngine syspref is a 'Break Koha' option switch as long as Elasticsearch Perl dependencies are not shipped/pulled. I agree we can workaround the about.pl problem. But we still have break switches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There has been talk about getting ElasticSearch production ready for 18.05 - I think if that is the goal, we should ship with the dependency. Is it hard to pack or are there other reasons against it? Size? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- My understanding was (In reply to Katrin Fischer from comment #3)
There has been talk about getting ElasticSearch production ready for 18.05 - I think if that is the goal, we should ship with the dependency. Is it hard to pack or are there other reasons against it? Size?
We already have it. It's just not needed without actually using ES. So far we have not added ES dependencies as mandatory to allow Koha to be run Zebra-only. Maybe it's not really an important question. AFAIK libsearch-elasticsearch-perl does not depend on actually installing Elasticsearch, so Zebra users don't have extra work. I agree with Tomas that having setting options that kill Koha is not a good thing. I'll reset to needs signoff, feel free to go back to more discussion if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- My bad, there is no code to sign off :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 72116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72116&action=edit Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl Adds Search::Elasticsearch to Perldependencies.pm Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 72117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72117&action=edit Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl / d/control update debian/control. this file is auto generated. no testing required. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #8 from Mirko Tietgen <mirko@abunchofthings.net> --- Sorry Tomas, I stole your bug. I can offer you a signoff though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Assignee|tomascohen@gmail.com |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72116|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 72118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72118&action=edit Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl Adds Search::Elasticsearch to Perldependencies.pm Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72117|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 72119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72119&action=edit Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl / d/control update debian/control. this file is auto generated. no testing required. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Mirko Tietgen from comment #8)
Sorry Tomas, I stole your bug. I can offer you a signoff though.
Thanks :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Is this suitable for backporting Mirko? or is anything else needed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 --- Comment #14 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Nick Clemens from comment #13)
Is this suitable for backporting Mirko? or is anything else needed?
Nick: You skipped bug 19542, so you can skip this one too. I think it should go to resolved fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org