[Bug 9071] New: Updates adding systempreferences should verify the absence of those preferences prior to attempting to add them
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 Priority: P5 - low Change sponsored?: --- Bug ID: 9071 CC: gmcharlt@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Updates adding systempreferences should verify the absence of those preferences prior to attempting to add them Severity: enhancement Classification: Unclassified OS: All Reporter: cnighswonger@foundations.edu Hardware: All Status: NEW Version: master Component: Installation and upgrade (web-based installer) Product: Koha Performing a blind INSERT of a new system preference causes the webinstaller to complain loudly. If the user happens to have DEBUG set, updatedatabase.pl bails on the error. In any case, this is generally bad behavior, and should be fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |cnighswonger@foundations.ed |ity.org |u Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #1 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- It would also clear up those annoying "this table already exists" errors for devs (when their database already has the table due to testing or whatever). I approve. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Is this bug still valid, and if so should it still be assigned? This sounds like something that might be considered as a coding guideline rather than something to be patched, or was it planned to retroactively fix updatedatabase.pl? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #3 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Owen Leonard from comment #2)
Is this bug still valid, and if so should it still be assigned?
AFAIK it manifests in upgrades from older versions. Not sure if it shows up when upgrading from more recent versions.
This sounds like something that might be considered as a coding guideline rather than something to be patched, or was it planned to retroactively fix updatedatabase.pl?
It was a hope to code up a routine to be called before each INSERT to verify existence. A coding guidline would be helpful as well. Setting it back to NEW since I'm not in the position to fix it atm. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m, | |katrin.fischer@bsz-bw.de, | |kyle@bywatersolutions.com, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- The good practice would be to have an "insert ignore into" statement. But actually you are right, we missed a lot of "insert into" without any check. QAers should keep a closed eye on this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Sounds like we can close this report? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 --- Comment #6 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to M. de Rooy from comment #5)
Sounds like we can close this report?
Had the problem been addressed in a sustainable way? I'm not sure it has. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- It should be added to the coding guidelines and catched by QAers for new patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 --- Comment #8 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Jonathan Druart from comment #7)
It should be added to the coding guidelines and catched by QAers for new patches.
I'd like to see it added and a link posted here when the bug is marked resolved for continuity's sake. I'm working on my phone or I'd do it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Added on http://wiki.koha-community.org/wiki/System_Preferences#Adding_a_new_system_p... and http://wiki.koha-community.org/wiki/Database_updates#updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- + http://lists.koha-community.org/pipermail/koha-devel/2015-April/041310.html -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9327 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org