[Bug 24158] New: Receive items in multiple currencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Bug ID: 24158 Summary: Receive items in multiple currencies Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org When receiving items, add a currency dropdown to the Actual Cost field in the Accounting Details panel. The currency dropdown will list all currencies on the system that have an exchange rate specified. When a currency is selected a conversion will be made from the selected currency to the currency marked as active at the exchange rate specified at the point of receipt. The converted amount will be shown in the Accounting Details panel and written to the database when the form is submitted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mark.gavillet@ptfs-europe.c | |om Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96263&action=edit Bug 24158: Convert actual cost in an other currency when receiving This patch adds a currency dropdown list to the Actual cost field when receiving items in the acquisition module. The idea is to let the librarian entered a price in a foreign currency that will automatically be converted in the local currency ('active'). This converted value will be use as the actual cost once the form is submitted. Test plan: - Create several currencies with different rates - Create an order, close the basket and receive - On the receipt page you will notice a new "change currency" checkbox right close to the 'Actual cost' input. - Check it => The 'Actual cost' input is readonly and a new line appears at the bottom. - Enter a number and select a currency => The 'Actual cost' input is automatically filled with the converted value - Save => The converted Actual cost has been inserted in the database. Sponsored-by: Athlone Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored-by: Athlone release notes| |Institute of Technology --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The implementation differs a bit from what was specified originally. I have tried several versions of this and ended up with this one, which seems the more ergonomic and intuitive in my opinion. https://snipboard.io/FhkwAS.jpg https://snipboard.io/GqrsVE.jpg https://snipboard.io/GhRLav.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96263|0 |1 is obsolete| | --- Comment #3 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 99766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99766&action=edit Bug 24158: Convert actual cost in an other currency when receiving This patch adds a currency dropdown list to the Actual cost field when receiving items in the acquisition module. The idea is to let the librarian entered a price in a foreign currency that will automatically be converted in the local currency ('active'). This converted value will be use as the actual cost once the form is submitted. Test plan: - Create several currencies with different rates - Create an order, close the basket and receive - On the receipt page you will notice a new "change currency" checkbox right close to the 'Actual cost' input. - Check it => The 'Actual cost' input is readonly and a new line appears at the bottom. - Enter a number and select a currency => The 'Actual cost' input is automatically filled with the converted value - Save => The converted Actual cost has been inserted in the database. Sponsored-by: Athlone Institute of Technology Signed-off-by: Devinim <nazli@devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kohadevinim@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA tools fail: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt FAIL filters missing_filter at line 308 ( <option value="[% active_currency.rate %]" selected="selected">[% active_currency.currency %] ([% active_currency.symbol %])</option>) missing_filter at line 308 ( <option value="[% active_currency.rate %]" selected="selected">[% active_currency.currency %] ([% active_currency.symbol %])</option>) missing_filter at line 308 ( <option value="[% active_currency.rate %]" selected="selected">[% active_currency.currency %] ([% active_currency.symbol %])</option>) missing_filter at line 310 ( <option value="[% currency.rate %]">[% currency.currency %] ([% currency.symbol %])</option>) missing_filter at line 310 ( <option value="[% currency.rate %]">[% currency.currency %] ([% currency.symbol %])</option>) missing_filter at line 310 ( <option value="[% currency.rate %]">[% currency.currency %] ([% currency.symbol %])</option>) I know this will bounce back quickly :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101402&action=edit Bug 24158: Add missing html filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works for me, but I have some big question marks about the currency calculation on receive: If you have set 'invoice prices' to another currency than standard in the vendor, this is not visible anywhere in the receive form. And it doesn't appear to be taken into account? I set 'invoice price' to USD and the rate to 3. Then entered 10 on receive and expected it to be converted to 30, but it didn't happen :( Where is this setting used and how will it possibly affect this change here? My impression was that you will enter the price in the currency set in the vendor, like you do for the ordering price and it will recalculate, but that doesn't seem to happen. I'd like this to be cleared up, before we move on with this to make sure we don't step on toes/workflows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested on 18.11 as well - not sure what the invoice price setting is used for still :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Talked with Katrin. We may want to preselect the new dropdown list to the value of the invoiceprice's vendor. But that would be for a follow-up bug anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99766|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101682&action=edit Bug 24158: Convert actual cost in an other currency when receiving This patch adds a currency dropdown list to the Actual cost field when receiving items in the acquisition module. The idea is to let the librarian entered a price in a foreign currency that will automatically be converted in the local currency ('active'). This converted value will be use as the actual cost once the form is submitted. Test plan: - Create several currencies with different rates - Create an order, close the basket and receive - On the receipt page you will notice a new "change currency" checkbox right close to the 'Actual cost' input. - Check it => The 'Actual cost' input is readonly and a new line appears at the bottom. - Enter a number and select a currency => The 'Actual cost' input is automatically filled with the converted value - Save => The converted Actual cost has been inserted in the database. Sponsored-by: Athlone Institute of Technology Signed-off-by: Devinim <nazli@devinim.com.tr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101402|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101683&action=edit Bug 24158: Add missing html filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24971 [Bug 24971] Select invoice currency from vendor on receive -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Summary|Receive items in multiple |Add ability to receive |currencies |items in multiple | |currencies Text to go in the|Sponsored-by: Athlone | release notes|Institute of Technology | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |currency dropdown to the | |actual cost field on the | |accounting details panel at | |the point of receipt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25655 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org