[Bug 34115] New: When editing bibliographic frameworks, the right tab is not always preselected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Bug ID: 34115 Summary: When editing bibliographic frameworks, the right tab is not always preselected Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org There are 2 small regressions here that probably happened when the tabs handling was updated: 1) Shortcut to edit a subfield from search form This is a somewhat hidden feature, but really nice: * Go to administration > bibliographic frameworks * Any framework > MARC structure * "Search for tag" enter 245$b --> Verify you see the edit form, but tab 0 is active 2) Shortcut to edit a subfield from subfield letter/number * Go to administration > bibliographic frameworks * Any framework > MARC structure * Search for 952 * Actions > View subfields * Click on any subfield but 0 --> Verify you see the edit form, but tab 0 is active -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|22.11 |master Summary|When editing bibliographic |Use a global tab select |frameworks, the right tab |function for activating |is not always preselected |Bootstrap tabs based on | |location hash -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152651&action=edit Bug 34115: Use a global tab select function for activating Bootstrap tabs based on location hash This patch fixes automatic tab selection by location.hash in the MARC subfield editor. This allows links which target a specific subfield to open the page with the subfield tab selected. I've put this into a global function since it can be reused in multiple places: The about page and the checkout page have variations of this functionality which can be replaced with this function. The patch also corrects two links in Koha pointing to the About page which included the wrong location hash (changed in the switch to Bootstrap tab wrappers). To test, apply the patch and go to Adminstration -> Bibliographic frameworks. - View the MARC structure for any framework. - In the "Search for tag" input field, submit a tag and subfield which will be found in that framework, e.g. "245$a" - When you submit the form you should be sent to the MARC subfield structure page for that tag with the subfield tab automatically selected. - View the MARC subfield structure for any framework. - In the table of subfields, click the subfield link in the first column. You should be taken to the edit form with the corresponding tab selected. - Go to Circulation and check out to a patron. Append a tab anchor to the URL, e.g. "#holds_panel" and submit. You may have to shift-reload the page to see the change. (As far as I know no links in Koha take advantage of this) - Perform the same test on the patron detail page - Go to the About page and perform the same test with a tab anchor like "#team_panel" or "#sysinfo_panel" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152651|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153058&action=edit Bug 34115: Use a global tab select function for activating Bootstrap tabs based on location hash This patch fixes automatic tab selection by location.hash in the MARC subfield editor. This allows links which target a specific subfield to open the page with the subfield tab selected. I've put this into a global function since it can be reused in multiple places: The about page and the checkout page have variations of this functionality which can be replaced with this function. The patch also corrects two links in Koha pointing to the About page which included the wrong location hash (changed in the switch to Bootstrap tab wrappers). To test, apply the patch and go to Adminstration -> Bibliographic frameworks. - View the MARC structure for any framework. - In the "Search for tag" input field, submit a tag and subfield which will be found in that framework, e.g. "245$a" - When you submit the form you should be sent to the MARC subfield structure page for that tag with the subfield tab automatically selected. - View the MARC subfield structure for any framework. - In the table of subfields, click the subfield link in the first column. You should be taken to the edit form with the corresponding tab selected. - Go to Circulation and check out to a patron. Append a tab anchor to the URL, e.g. "#holds_panel" and submit. You may have to shift-reload the page to see the change. (As far as I know no links in Koha take advantage of this) - Perform the same test on the patron detail page - Go to the About page and perform the same test with a tab anchor like "#team_panel" or "#sysinfo_panel" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153058|0 |1 is obsolete| | --- Comment #3 from Sam Lau <samalau@gmail.com> --- Created attachment 153070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153070&action=edit Bug 34115: Use a global tab select function for activating Bootstrap tabs based on location hash This patch fixes automatic tab selection by location.hash in the MARC subfield editor. This allows links which target a specific subfield to open the page with the subfield tab selected. I've put this into a global function since it can be reused in multiple places: The about page and the checkout page have variations of this functionality which can be replaced with this function. The patch also corrects two links in Koha pointing to the About page which included the wrong location hash (changed in the switch to Bootstrap tab wrappers). To test, apply the patch and go to Adminstration -> Bibliographic frameworks. - View the MARC structure for any framework. - In the "Search for tag" input field, submit a tag and subfield which will be found in that framework, e.g. "245$a" - When you submit the form you should be sent to the MARC subfield structure page for that tag with the subfield tab automatically selected. - View the MARC subfield structure for any framework. - In the table of subfields, click the subfield link in the first column. You should be taken to the edit form with the corresponding tab selected. - Go to Circulation and check out to a patron. Append a tab anchor to the URL, e.g. "#holds_panel" and submit. You may have to shift-reload the page to see the change. (As far as I know no links in Koha take advantage of this) - Perform the same test on the patron detail page - Go to the About page and perform the same test with a tab anchor like "#team_panel" or "#sysinfo_panel" Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153070|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153213&action=edit Bug 34115: Use a global tab select function for activating Bootstrap tabs based on location hash This patch fixes automatic tab selection by location.hash in the MARC subfield editor. This allows links which target a specific subfield to open the page with the subfield tab selected. I've put this into a global function since it can be reused in multiple places: The about page and the checkout page have variations of this functionality which can be replaced with this function. The patch also corrects two links in Koha pointing to the About page which included the wrong location hash (changed in the switch to Bootstrap tab wrappers). To test, apply the patch and go to Adminstration -> Bibliographic frameworks. - View the MARC structure for any framework. - In the "Search for tag" input field, submit a tag and subfield which will be found in that framework, e.g. "245$a" - When you submit the form you should be sent to the MARC subfield structure page for that tag with the subfield tab automatically selected. - View the MARC subfield structure for any framework. - In the table of subfields, click the subfield link in the first column. You should be taken to the edit form with the corresponding tab selected. - Go to Circulation and check out to a patron. Append a tab anchor to the URL, e.g. "#holds_panel" and submit. You may have to shift-reload the page to see the change. (As far as I know no links in Koha take advantage of this) - Perform the same test on the patron detail page - Go to the About page and perform the same test with a tab anchor like "#team_panel" or "#sysinfo_panel" Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a bug fix - please consider for backporting! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.04 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org