[Bug 38453] New: Make koha-l10n get upgraded as a Koha dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38453 Bug ID: 38453 Summary: Make koha-l10n get upgraded as a Koha dependency Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com When the koha-common package is upgraded, it should cause koha-l10n to get upgraded as well. The koha-common package by default automatically updates translations post-install. This is redundant if the upgraded koha-l10n package hasn't also been installed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38453 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make koha-l10n get upgraded |Make koha-l10n get upgraded |as a Koha dependency |when koha-common gets | |upgraded -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38453 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |mtj@kohaaloha.com Component|Installation and upgrade |Packaging |(command-line installer) | --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I've been thinking about this topic on and off for a little while regarding Debian packages in general... Typically, one hard-codes required version numbers for dependencies into debian/control (or whatever process that builds it like debian/update-control in Koha). But we don't usually know the Koha/koha-l10n version until we give it to debian/build-git-snapshot (or an alternative Koha Debian package builder if you're me) which is a fairly last minute thing... We use dch -v to set the version number, which should flow through to one of the variables listed in "man deb-substvars" such as source:Version or binary:Version. That said... I don't know how well that will work for custom Debian packages which rely on the community koha-l10n package. So we might need to think of something a bit different. Possibly a custom variable in debian/control (and debian/control.in naturally), and then I think the version could be managed in debian/rules. Anyway, food for thought. Moving this to the Packaging component. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38453 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- (In reply to Aleisha Amohia from comment #0)
When the koha-common package is upgraded, it should cause koha-l10n to get upgraded as well.
The koha-common package by default automatically updates translations post-install.
This is redundant if the upgraded koha-l10n package hasn't also been installed.
hi Aleisha i think this already happens... in the following example, when koha-common is upgraded, the koha-l10n package is automatically upgraded before it # apt list -u Listing... Done koha-common/stable,stable 24.11.01-2 all [upgradable from: 24.05.06-1] koha-l10n/stable,stable 24.11.01-1 all [upgradable from: 24.05.06-1] # apt upgrade koha-common The following packages will be upgraded: koha-common koha-l10n 2 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. Need to get 52.6 MB of archives. After this operation, 11.0 MB of additional disk space will be used. Do you want to continue? [Y/n] Get:1 http://debian.koha-community.org/koha 24.11/main amd64 koha-l10n all 24.11.01-1 [33.8 MB] Get:2 http://debian.koha-community.org/koha 24.11/main amd64 koha-common all 24.11.01-2 [18.8 MB] Fetched 52.6 MB in 38s (1372 kB/s) Preconfiguring packages ... (Reading database ... 185719 files and directories currently installed.) Preparing to unpack .../koha-l10n_24.11.01-1_all.deb ... Unpacking koha-l10n (24.11.01-1) over (24.05.06-1) ... Preparing to unpack .../koha-common_24.11.01-2_all.deb ... Unpacking koha-common (24.11.01-2) over (24.05.06-1) ... Setting up koha-l10n (24.11.01-1) ... Setting up koha-common (24.11.01-2) ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38453 --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Maybe it has been fixed then. When I reported this a few months ago it certainly didn't work that way. I'll close this once the next minor point comes out and can confirm it's working as expected :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38453 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Mason James from comment #2)
i think this already happens...
# apt upgrade koha-common The following packages will be upgraded: koha-common koha-l10n
(In reply to Aleisha Amohia from comment #3)
Maybe it has been fixed then. When I reported this a few months ago it certainly didn't work that way.
I'll close this once the next minor point comes out and can confirm it's working as expected :)
I think that maybe you're both right. This was bugging me, so I did a comparison of "apt-get install" and "apt-get upgrade". If you do "apt-get install koha-common" to upgrade koha-common, it appears that apt will only upgrade that package. But if you do "apt-get upgrade koha-common", it will upgrade koha-common and its dependencies. Not sure how well that translates to tools like Ansible which abstract the install/upgrade process. Because the difference comes from the Debian tooling, it might be the safest to do something like "apt-get install koha-common koha-l10n" for targeted upgrades. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38453 --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to David Cook from comment #4)
(In reply to Mason James from comment #2)
i think this already happens...
# apt upgrade koha-common The following packages will be upgraded: koha-common koha-l10n
(In reply to Aleisha Amohia from comment #3)
Maybe it has been fixed then. When I reported this a few months ago it certainly didn't work that way.
I'll close this once the next minor point comes out and can confirm it's working as expected :)
I think that maybe you're both right.
This was bugging me, so I did a comparison of "apt-get install" and "apt-get upgrade".
If you do "apt-get install koha-common" to upgrade koha-common, it appears that apt will only upgrade that package. But if you do "apt-get upgrade koha-common", it will upgrade koha-common and its dependencies.
ooh, you are correct here. i did not know this
Not sure how well that translates to tools like Ansible which abstract the install/upgrade process.
Because the difference comes from the Debian tooling, it might be the safest to do something like "apt-get install koha-common koha-l10n" for targeted upgrades.
...or 'apt-get upgrade koha-common' would work too -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38453 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Mason James from comment #5)
Because the difference comes from the Debian tooling, it might be the safest to do something like "apt-get install koha-common koha-l10n" for targeted upgrades.
...or 'apt-get upgrade koha-common' would work too
In most cases I'd say so, although it would also upgrade any updated package that koha-common depends on including ones from Debian, so you might upgrade a package that you didn't mean to upgrade. (Although that could be a good thing in some/most cases.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38453 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We've noticed some issues with i18n, but not enough to put into written words yet, now I wonder if this thread is related. Please keep in mind to document findings! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org