[Bug 37574] New: Add visual indicator that bookings are expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Bug ID: 37574 Summary: Add visual indicator that bookings are expired Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We should add a text and possibly a color to highlight expired bookings when displayed to make it more obvious. Bug 37141 will display expired bookings by default on a patron with no active bookings, the filter button does say 'Hide expired' but making the rows more obviously expired would be nice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37141 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 [Bug 37141] Add option to display completed bookings from patron page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170132&action=edit Bug 37574: Add visual indicator that bookings are expired Adds a status column to the table configuration that displays whether a booking is active or expired (at the moment). This column is conditionally shown in the 'Show Expired' state, meaning after expired bookings are loaded into the table. To test: 1) Create a couple booking for any item for a single patron. 2) Open a db shell with `koha-mysql <INSTANCE>` 3) Update one or two of the created bookings with: update bookings set start_date = '<date in the past>', end_date = '<date also in the past'> where booking_id = '<booking id of the booking you just created>'. 4) Go the the bookings tab of said item. 5) Click the 'Show Expired' option in the top left of the table. 6) Note that bookings are tagged with 'Expired' and 'Active'. 7) Repeat 5 and 6 for the bookings tab in the patron's details view. 8) Sign off. Note: the bootstrap classes for v5 are already included so they become colored once the patch is in. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I'm getting an error when I try to reorder the table by status: ==> /var/log/koha/kohadev/plack-api-error.log <== [2024/08/07 14:14:59] [ERROR] GET /api/v1/bookings: unhandled exception (DBIx::Class::Exception)<<DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me' in 'order clause' at /kohadevbox/koha/Koha/Objects.pm line 403>> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Ah, thought that was client side. Will remove the 'orderable' property until there's a db column for it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170151&action=edit Bug 37574: (follow-up) disable ordering and searching on status column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170132|0 |1 is obsolete| | Attachment #170151|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170159&action=edit Bug 37574: Add visual indicator that bookings are expired Adds a status column to the table configuration that displays whether a booking is active or expired (at the moment). This column is conditionally shown in the 'Show Expired' state, meaning after expired bookings are loaded into the table. To test: 1) Create a couple booking for any item for a single patron. 2) Open a db shell with `koha-mysql <INSTANCE>` 3) Update one or two of the created bookings with: update bookings set start_date = '<date in the past>', end_date = '<date also in the past'> where booking_id = '<booking id of the booking you just created>'. 4) Go the the bookings tab of said item. 5) Click the 'Show Expired' option in the top left of the table. 6) Note that bookings are tagged with 'Expired' and 'Active'. 7) Repeat 5 and 6 for the bookings tab in the patron's details view. 8) Sign off. Note: the bootstrap classes for v5 are already included so they become colored once the patch is in. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170160&action=edit Bug 37574: (follow-up) disable ordering and searching on status column Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |me@paulderscheid.xyz |ity.org | QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170159|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170382&action=edit Bug 37574: Add visual indicator that bookings are expired Adds a status column to the table configuration that displays whether a booking is active or expired (at the moment). This column is conditionally shown in the 'Show Expired' state, meaning after expired bookings are loaded into the table. To test: 1) Create a couple booking for any item for a single patron. 2) Open a db shell with `koha-mysql <INSTANCE>` 3) Update one or two of the created bookings with: update bookings set start_date = '<date in the past>', end_date = '<date also in the past'> where booking_id = '<booking id of the booking you just created>'. 4) Go the the bookings tab of said item. 5) Click the 'Show Expired' option in the top left of the table. 6) Note that bookings are tagged with 'Expired' and 'Active'. 7) Repeat 5 and 6 for the bookings tab in the patron's details view. 8) Sign off. Note: the bootstrap classes for v5 are already included so they become colored once the patch is in. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170160|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170383&action=edit Bug 37574: (follow-up) disable ordering and searching on status column Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice addition, all working as expected and doesn't block any future developments or cause any regressions. Passing QA, Thanks Paul! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |bookings function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|me@paulderscheid.xyz |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Translatability This is in a .tt file, so we need the single underscore: + title: __("Status"), Fixed in a follow-up patch. I notice we have almost the same code in a .js as well, with the correct double underscore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |visual indicator for | |expired bookings in the | |bookings table by | |displaying a status column | |with 'Expired' and 'Active' | |labels, making it easier to | |identify expired bookings | |when viewing or filtering | |them. | | | |**Sponsored by** | |*Büchereizentrale | |Schleswig-Holstein* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37574 Bug 37574 depends on bug 37141, which changed state. Bug 37141 Summary: Add option to display completed bookings from patron page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37141 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org