[Bug 16023] New: Use Font Awesome icons on audio alerts page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Bug ID: 16023 Summary: Use Font Awesome icons on audio alerts page Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/audio_alerts.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 15886 The audio alerts page uses Glyphicons in a few places. They should be replaced with Font Awesome icons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15886 [Bug 15886] Revise layout and behavior of audio alerts management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48877&action=edit Bug 16023 - Use Font Awesome icons on audio alerts page The audio alerts management page uses Glyphicons in a few places. This patch replaces them with Font Awesome icons. To test, apply the patch for Bug 15886 if necessary and enable the AudioAlerts system preference. - Go to Administration -> Audio alerts - Confirm that icons for "Edit" and "Delete selected" look correct. - Edit an existing alert and confirm that the "play" button looks correct and works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16023 - Use Font Awesome icons on audio alerts page fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 16023 - Use Font Awesome icons on audio alerts page The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-16023---Use-Font-Awesome-icons-on-audio-alerts-wqIpkQ.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- The dependency (Bug 15886) has been pushed to master, so this should apply with no extra steps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48877|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 49180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49180&action=edit Bug 16023 - Use Font Awesome icons on audio alerts page The audio alerts management page uses Glyphicons in a few places. This patch replaces them with Font Awesome icons. To test, apply the patch for Bug 15886 if necessary and enable the AudioAlerts system preference. - Go to Administration -> Audio alerts - Confirm that icons for "Edit" and "Delete selected" look correct. - Edit an existing alert and confirm that the "play" button looks correct and works correctly. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 [Bug 16080] Remove unused images from the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49180|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49207&action=edit Bug 16023 - Use Font Awesome icons on audio alerts page The audio alerts management page uses Glyphicons in a few places. This patch replaces them with Font Awesome icons. To test, apply the patch for Bug 15886 if necessary and enable the AudioAlerts system preference. - Go to Administration -> Audio alerts - Confirm that icons for "Edit" and "Delete selected" look correct. - Edit an existing alert and confirm that the "play" button looks correct and works correctly. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 --- Comment #6 from Marc Véron <veron@veron.ch> --- Hi Jonathan, you switched the bug back to Needs Signoff - is that intended? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49207|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 49369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49369&action=edit Bug 16023 - Use Font Awesome icons on audio alerts page The audio alerts management page uses Glyphicons in a few places. This patch replaces them with Font Awesome icons. To test, apply the patch for Bug 15886 if necessary and enable the AudioAlerts system preference. - Go to Administration -> Audio alerts - Confirm that icons for "Edit" and "Delete selected" look correct. - Edit an existing alert and confirm that the "play" button looks correct and works correctly. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Marc Véron from comment #6)
Hi Jonathan, you switched the bug back to Needs Signoff - is that intended?
I don't know. But, it looks like it is fine to me, hence my sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49369|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49380&action=edit [PASSED QA] Bug 16023 - Use Font Awesome icons on audio alerts page The audio alerts management page uses Glyphicons in a few places. This patch replaces them with Font Awesome icons. To test, apply the patch for Bug 15886 if necessary and enable the AudioAlerts system preference. - Go to Administration -> Audio alerts - Confirm that icons for "Edit" and "Delete selected" look correct. - Edit an existing alert and confirm that the "play" button looks correct and works correctly. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org