[Bug 39293] New: Remove box around subfield tag in basic editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Bug ID: 39293 Summary: Remove box around subfield tag in basic editor Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 179128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179128&action=edit bib edit screen in main In 24.11 and later, the bootstrap update seems to have put a box around subfield tags (see attached screenshot). These values have been editable for a long time, but putting boxes around them makes it really clear that this is possible. But manual editing of those subfield tags is not really the expected way to use this editor and opens one up to numerous cataloging errors. For this sort of unguided cataloging, we expect one to use the advanced editor. I suggest we make those boxes go away again to make this questionable feature less obvious. If we leave the boxes, we really need to fix bug 29253, in which one can use this subfield updating to violate framework constraints. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- oops, put the wrong bug number in that comment. Bug 29253 is not relevant here, but bug 39292 is! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- If we were going to intentionally show the border in just one of the two editors, I would have picked adding it in the authority editor, where I use the ability to edit subfield letters all the time. For bib records, if you do that much editing of existing subfield codes you really ought to spend an hour learning to use the advanced editor, where you can just type them directly. But I doubt it was intentional, since the lack of border comes from an awkwardly placed border:0; in a style attribute in the template, where it looks more like a mistake than the attempt to obscure a feature that it actually is. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179190&action=edit Bug 39293: Remove box around subfield tag in basic editor Prior to the Bootstrap 5 update, the feature of editing subfield codes in the basic editor was kept subtle by putting the code in an <input>, but removing the border around the input, so it required either knowing the feature exists or accidentally clicking on or around the single letter code and seeing it turn into an editable input. This patch removes the border again, because when people accidentally see the feature, they are sometimes not pleased to see it. Test plan: 1. Without the patch, open the cataloging basic editor and switch to the "1" tab with the 100 fields. 2. Note that the codes for the subfields are clearly in editable inputs. 3. Apply patch, reload the editor page. 4. Note that now the codes look like just plain text, until you actually click on or very near the letter, when they become visible as inputs by having the focus border. Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179190|0 |1 is obsolete| | --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Comment on attachment 179190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179190 Bug 39293: Remove box around subfield tag in basic editor Gee, thanks tidy, completely removing addbiblio.tt sounds like a great idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179221&action=edit Bug 39293: Remove box around subfield tag in basic editor Prior to the Bootstrap 5 update, the feature of editing subfield codes in the basic editor was kept subtle by putting the code in an <input>, but removing the border around the input, so it required either knowing the feature exists or accidentally clicking on or around the single letter code and seeing it turn into an editable input. This patch removes the border again, because when people accidentally see the feature, they are sometimes not pleased to see it. Test plan: 1. Without the patch, open the cataloging basic editor and switch to the "1" tab with the 100 fields. 2. Note that the codes for the subfields are clearly in editable inputs. 3. Apply patch, reload the editor page. 4. Note that now the codes look like just plain text, until you actually click on or very near the letter, when they become visible as inputs by having the focus border. Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179221|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 179231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179231&action=edit Bug 39293: Remove box around subfield tag in basic editor Prior to the Bootstrap 5 update, the feature of editing subfield codes in the basic editor was kept subtle by putting the code in an <input>, but removing the border around the input, so it required either knowing the feature exists or accidentally clicking on or around the single letter code and seeing it turn into an editable input. This patch removes the border again, because when people accidentally see the feature, they are sometimes not pleased to see it. Test plan: 1. Without the patch, open the cataloging basic editor and switch to the "1" tab with the 100 fields. 2. Note that the codes for the subfields are clearly in editable inputs. 3. Apply patch, reload the editor page. 4. Note that now the codes look like just plain text, until you actually click on or very near the letter, when they become visible as inputs by having the focus border. Sponsored-by: Chetco Community Public Library Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39321 [Bug 39321] Hide subfield tag for fixed length control fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179231|0 |1 is obsolete| | --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179500&action=edit Bug 39293: Remove box around subfield tag in basic editor Prior to the Bootstrap 5 update, the feature of editing subfield codes in the basic editor was kept subtle by putting the code in an <input>, but removing the border around the input, so it required either knowing the feature exists or accidentally clicking on or around the single letter code and seeing it turn into an editable input. This patch removes the border again, because when people accidentally see the feature, they are sometimes not pleased to see it. Test plan: 1. Without the patch, open the cataloging basic editor and switch to the "1" tab with the 100 fields. 2. Note that the codes for the subfields are clearly in editable inputs. 3. Apply patch, reload the editor page. 4. Note that now the codes look like just plain text, until you actually click on or very near the letter, when they become visible as inputs by having the focus border. Sponsored-by: Chetco Community Public Library Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.08 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 Discussion on chat shows the fact that subfield code is editable is not really a feature. So lets keep it has it was before ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39293 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org