[Bug 4498] New: Acq always shows '1 suggestions waiting'
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4498 Summary: Acq always shows '1 suggestions waiting' Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Acquisitions AssignedTo: chris@bigballofwax.co.nz ReportedBy: katrin.fischer@bsz-bw.de Estimated Hours: 0.0 Change sponsored?: --- Created an attachment (id=1896) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1896) screenshot In navigation of acquisitions there is always a link with '1 suggestions waiting' even when table suggestions is empty. Both '1 suggestions waiting' and 'Manage suggestions' link to suggestions.pl. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4498 Garry Collum <gcollum@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gcollum@gmail.com --- Comment #1 from Garry Collum <gcollum@gmail.com> 2010-05-18 21:18:33 --- It looks like <!-- TMPL_IF name="suggestion" --> in acquisitions-menu.inc is pulling its value from a global variable defined in Auth.pm - suggestion => C4::Context->preference("suggestion"). If patron suggestions are turned on you get a message indicating that there is one suggestion pending, if not you get a message that indicates that there are no messages. This could easily be fixed by changing the variable name to something like 'pendingsuggestions' and using the CountSuggestion function in Suggestions.pm to acquire a value, but does this code need to be in every .pl file whose template will include acquisitions-menu.inc, or can it be defined as a global module variable in either Suggestions.pm, or Acquisitions.pm? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon@kohaorg.ec2.liblime.com