https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- To recreate this I added this image with a width to 1000px to a News Item: <img src="https://koha-community.org/files/2013/09/cropped-kohabanner3.jpg" width="1000"> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 112296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112296&action=edit Bug 26804: Limit the size of the News column in newst table This patch attempts to make the table on koha-news.tt more manaagable by limiting the width of the 'News' column and adding a sticky thead so you know what column you are looking at when you scroll through News Items To Test: 1. Add some HTML to a News Item. I am using a bunch of lorem ipsum HTML and this image set to 1000px. '<img src="https://koha-community.org/files/2013/09/cropped-kohabanner3.jpg" width="1000" />' but I'm not your overlord so choose your own way. 2. Look at /cgi-bin/koha/tools/koha-news.pl and see all your content in the News column. With a large image you have to scroll a long way to see the action buttons (Edit, Delete) 3. Apply patch 4. Regenerate the staff CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 5. Clear you cache and again look at /cgi-bin/koha/tools/koha-news.pl. The table should only be 200px wide no matter the size of your content. 6. Scroll down and notice the thead stays with you. 7. Try testing at many different screen size. Question: Should we limit height as well? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112296|0 |1 is obsolete| | --- Comment #3 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 112407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112407&action=edit Bug 26804: Limit the size of the News column in newst table This patch attempts to make the table on koha-news.tt more manaagable by limiting the width of the 'News' column and adding a sticky thead so you know what column you are looking at when you scroll through News Items To Test: 1. Add some HTML to a News Item. I am using a bunch of lorem ipsum HTML and this image set to 1000px. '<img src="https://koha-community.org/files/2013/09/cropped-kohabanner3.jpg" width="1000" />' but I'm not your overlord so choose your own way. 2. Look at /cgi-bin/koha/tools/koha-news.pl and see all your content in the News column. With a large image you have to scroll a long way to see the action buttons (Edit, Delete) 3. Apply patch 4. Regenerate the staff CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 5. Clear you cache and again look at /cgi-bin/koha/tools/koha-news.pl. The table should only be 200px wide no matter the size of your content. 6. Scroll down and notice the thead stays with you. 7. Try testing at many different screen size. Question: Should we limit height as well? Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure about this change as it means you can't get a good impression of how a news entry will look like in the OPAC anymore and 200px appears a little too small while the other colums grow to take up more space than they need. I'd like to see if we can imagine another solution here. Maybe the width of the table could be limited so that at least this column can take up all the space available? Or maybe a link to display the entry full size? Trying to get some more opinions. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112407|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 112629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112629&action=edit Bug 26804: Add modal content preview This patch turns the 'News' column into a preview button. That preview button displays a modal with content of that rows news item. To test: 1. Apply patch 2. Add some HTML to a News Item. I am using a bunch of lorem ipsum HTML and this image set to 1000px. '<img src="https://koha-community.org/files/2013/09/cropped-kohabanner3.jpg" width="1000" />'. 3. Make sure and have some content with a lot of width and some content with a lot of height. 4. Test the Preview content button 5. Make sure you can scroll through long modals and across modals that are wide 6. Try at different screen sizes and with different combonations of News items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112639|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 112683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112683&action=edit Bug 26804: Add modal content preview This patch turns the 'News' column into a preview button. That preview button displays a modal with content of that rows news item. To test: 1. Apply patch 2. Add some HTML to a News Item. I am using a bunch of lorem ipsum HTML and this image set to 1000px. '<img src="https://koha-community.org/files/2013/09/cropped-kohabanner3.jpg" width="1000" />'. 3. Make sure and have some content with a lot of width and some content with a lot of height. 4. Test the Preview content button 5. Make sure you can scroll through long modals and across modals that are wide 6. Try at different screen sizes and with different combonations of News items Signed-off-by: Kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, thx a lot for reworking this. I feel with the current size of the modal we have the same issue as with the inline one, that it's too small to get a good impression. Could we have this a bit bigger? Or maybe at least as wide as the graphics in it? Sorry to bother you. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Owen, can we please have a follow-up? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Owen, modal-wide didn't work for me but modal-lg did. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112883|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112954&action=edit Bug 26804: (QA follow-up) add modal-lg class and intent markup correctly Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It may be a problem if the content is malformed, but the codemirror editor should prevent that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|News: Limit the size of the |News: Move the news preview |news content column in |out of the table and into a |newst table |modal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.