http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 17859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17859&action=edit pic -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Just confirmed with a customer that this seems to have been caused by the changes introduced under bug 5521 caused the problem - reverting that change got this working again ( but reintroduced the 5521 bug) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20056&action=edit Screenshot of batch operation after applying the patch This patch doesn't solve the problem for me. See the attached screenshot. I still don't get the option to make any modifications. The table and its related controls shouldn't be shown at all. All I should see is the message ("Too many items" -- and properly styled in a <div class="dialog message">) and the form for making modifications. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 45326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45326&action=edit Bug 10163 - batch-mod items tool fails on files over 1000 lines long When using batch modification tool, if number of items is too big (default 1000), the edit form is not displayed. In perl script, when number of items is too big, template var "item_loop" is not defined and var "too_many_items"is set. This patch allows the display of edit form and text "The following barcodes were found: " even when number of items is too big. Test plan : - Create a file with 11 existing barcodes and 1 not existing in catalogue - Set syspref MaxItemsForBatch to 1000 - Go to Tools > Batch item modification - Select "Barcode file" and upload file - Click on continue => you see a warning with the not found barcode, a table with found items and the edit form - Set syspref MaxItemsForBatch to 10 - Go to Tools > Batch item modification - Select "Barcode file" and upload file - Click on continue => you see a warning with the not found barcode and a text "Too many items ..." => Without patch you don't see the edit form => With patch you see the edit form and can perform the batc modifications -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18256|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Mason James from comment #0)

looking that the code its obvious that the intended behavior is to not display the items, yet still allow the items to be edited

Fridolin patch restores the above, ie the items are not displayed when there are more than MaxItemsForBatch items, but editing them globally is possible. The question may be that MaxItemsForBatch syspref states: Process up to MaxItemsForBatch in a single modification or deletion batch. It seems that the wording is not exactly true. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45326|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45723&action=edit [SIGNED-OFF] Bug 10163 - batch-mod items tool fails on files over 1000 lines long When using batch modification tool, if number of items is too big (default 1000), the edit form is not displayed. In perl script, when number of items is too big, template var "item_loop" is not defined and var "too_many_items"is set. This patch allows the display of edit form and text "The following barcodes were found: " even when number of items is too big. Test plan : - Create a file with 11 existing barcodes and 1 not existing in catalogue - Set syspref MaxItemsForBatch to 1000 - Go to Tools > Batch item modification - Select "Barcode file" and upload file - Click on continue => you see a warning with the not found barcode, a table with found items and the edit form - Set syspref MaxItemsForBatch to 10 - Go to Tools > Batch item modification - Select "Barcode file" and upload file - Click on continue => you see a warning with the not found barcode and a text "Too many items ..." => Without patch you don't see the edit form => With patch you see the edit form and can perform the batc modifications Signed-off-by: Owen Leonard <oleonard@myacpl.org> Test plan followed successfully. Item modifications completed correctly. -- You are receiving this mail because: You are watching all bug changes.