[Bug 8740] New: Serials Claims should be exportable all at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Priority: P5 - low Change sponsored?: Sponsored Bug ID: 8740 CC: colin.campbell@ptfs-europe.com Assignee: koha-bugs@lists.koha-community.org Summary: Serials Claims should be exportable all at once Severity: enhancement Classification: Unclassified OS: All Reporter: mjr@software.coop URL: http://intranet/cgi-bin/koha/serials/claims.pl Hardware: All Status: NEW Version: master Component: Serials Product: Koha At the moment, you have to step through vendors one at a time. It should be possible to see all overdues at once, if chosen explicitly because the list may be large. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 --- Comment #1 from MJ Ray (software.coop) <mjr@software.coop> --- Created attachment 12068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12068&action=edit enh bug 8740 Serials Claims should be exportable all at once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |mjr@software.coop |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 --- Comment #2 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 12155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12155&action=edit [SIGNED OFF]enh bug 8740 Serials Claims should be exportable all at once Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |joy@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12068|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comments: This patch allows $supplierid to be a string or an integer. We have some warnings in logs: Argument "all" isn't numeric in numeric eq (==) Maybe a better option would be to set the "all suppliers" value with -1. Marked as Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12155|0 |1 is obsolete| | --- Comment #4 from MJ Ray (software.coop) <mjr@software.coop> --- Created attachment 15788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15788&action=edit enh bug 8740 Serials Claims should be exportable all at once Test plan: 1. Visit Serials: Claims and look at the vendor list drop-down 2. select All 3. click OK 4. export them all -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15788|0 |1 is obsolete| | --- Comment #5 from MJ Ray (software.coop) <mjr@software.coop> --- Created attachment 15789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15789&action=edit enh bug 8740 Serials Claims should be exportable all at once Test plan: 1. Visit Serials: Claims and look at the vendor list drop-down 2. select All 3. click OK 4. export them all -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from MJ Ray (software.coop) <mjr@software.coop> --- I've rebased this and changed a == to an eq to avoid the warnings. I have not set the "all suppliers" value with -1 because I dislike magic numbers and it is possible (but unlikely unless you mess with the database directly) to have a vendor with id -1 which would become unselectable alone. I ask for reviews and maybe new signoffs, please. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Frederic Durand <frederic.durand@unilim.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15789|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16491&action=edit enh bug 8740 Serials Claims should be exportable all at once Test plan: 1. Visit Serials: Claims and look at the vendor list drop-down 2. select All 3. click OK 4. export them all Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Sorry MJ but the warning still occur when the string is not initialized: Use of uninitialized value $supplierid in string eq at /home/koha/src/serials/claims.pl line 71 Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org