[Bug 28478] New: MARC detail and ISBD pages still show suppressed records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Bug ID: 28478 Summary: MARC detail and ISBD pages still show suppressed records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org I couldn't verify on master yet, but tested on 20.11.05: When a record is suppressed in the catalog using 942$n=1 and OpacSuppression a direct link to the MARCdetail page will still work: /cgi-bin/koha/opac-MARCdetail.pl?biblionumber=x This is problematic as some search bots could still index the records and someone clever would also be able to guess it. I think we need to add checks for suppression on these pages and redirect according to OpacSuppressionRedirect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Arf indeed, code in only in opac-detail.pl : https://git.koha-community.org/Koha-community/Koha/src/commit/3ba74940ee730e... This needs to be in a module, and if possible with a Koha to MARC mapping instead of hardcoded 942$n. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10195 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 [Bug 10195] Records hidden with OpacSuppression can still be accessed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #1)
Arf indeed, code in only in opac-detail.pl :
https://git.koha-community.org/Koha-community/Koha/src/commit/ 3ba74940ee730e92ad7061f27f18390cc6308364/opac/opac-detail.pl#L147
This needs to be in a module, and if possible with a Koha to MARC mapping instead of hardcoded 942$n.
I think adding a Koha to MARC mapping could be a different bug, also to keep this as easy as possible for backporting. Possibly the code for the check should also be in a routine somewhere? For MARC21 942$n has been established as standard and has a matching index. I am not sure if UNIMARC has a standard mapping at the moment? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #2)
(In reply to Fridolin Somers from comment #1)
Arf indeed, code in only in opac-detail.pl :
https://git.koha-community.org/Koha-community/Koha/src/commit/ 3ba74940ee730e92ad7061f27f18390cc6308364/opac/opac-detail.pl#L147
This needs to be in a module, and if possible with a Koha to MARC mapping instead of hardcoded 942$n.
I think adding a Koha to MARC mapping could be a different bug, also to keep this as easy as possible for backporting.
Sure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Should we add to Koha::Biblio hidden_in_opac() ? Maybe with a param 'context' = 'search' or 'details' ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |MARC Bibliographic data | |support Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Version|unspecified |Main Component|Koha |OPAC Version(s)| |24.11.02,24.05.07,23.11.12, released in| |22.11.24 QA Contact| |testopia@bugs.koha-communit | |y.org Product|Koha security |Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.02,24.05.07,23.11.12, |25.05.00,24.11.02,24.05.07, released in|22.11.24 |23.11.12,22.11.24 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178572|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178573|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178574|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00,24.11.02,24.05.07, |25.05.00,24.11.02,24.05.07 released in|23.11.12,22.11.24 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)|25.05.00,24.11.02,24.05.07 |25.05.00,25.05.00,24.11.02, released in| |24.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00,25.05.00,24.11.02, |25.05.00,24.11.02,24.05.07 released in|24.05.07 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36625 [Bug 36625] t/db_dependent/Koha/Biblio.t leaves test data in the database -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org