[Bug 13399] New: Select a department: empty field if no description set in authorized value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Bug ID: 13399 Summary: Select a department: empty field if no description set in authorized value Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: mirko@abunchofthings.net QA Contact: testopia@bugs.koha-community.org When you set up an authorized value in the DEPARTMENT category without descriptions, the pull down menu in course creation shows an empty value. It should instead fall back to the name of the authorized value. 1. Set up an authorized value in the DEPARTMENT category. Leave description fields empty. 2. Go to Course reserves, Create course. 3. Open the »Select a department« pull down menu, observe that there is no description Expected: display the name of the authorized value if no description is given. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu --- Comment #1 from Tom Misilo <misilot@fit.edu> --- Created attachment 36242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36242&action=edit Proposed Patch I don't have a system to test this on yet, however I believe this should do what you want. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Sorry, patch does not apply: git bz apply 13399 36242 - Proposed Patch Applying: Add check to determine if d.lib exists fatal: corrupt patch at line 20 Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Add check to determine if d.lib exists -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36242|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37532&action=edit Add check to determine if d.lib exists Add a check to see if d.lib exists, if it does display that value. Otherwise display the authorised value -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Rescued Tom's patch. It looks good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #5 from Tom Misilo <misilot@fit.edu> --- Thanks for fixing the patch! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- This does not work, it's not filled with the value everywhere it is displayed. It should be fixed on a higher level, for all authorised values I think (C4::Koha::GetAuthorisedValues and some others). Or maybe the best way would be to make the description mandatory on the AV administration page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #6)
Or maybe the best way would be to make the description mandatory on the AV administration page.
I think this is a better solution, yes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37783&action=edit Bug 13399: Missing validation on authorised value descriptions This adds validations which force both the OPAC and Staff Client authorised value descriptions to be filled in. Counter Patch in the works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37783|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37784&action=edit Bug 13399: Missing validation on authorised value descriptions This adds validations which force both the OPAC and Staff Client authorized value descriptions to be filled in. TEST PLAN --------- 1) Login to staff client 2) Koha administration -> Authorized values 3) Change drop-down to 'DEPARTMENT' -- Assuming you have default values installed, and DEPARTMENT exists. 4) Click '+ New authorized value for DEPARTMENT' 5) Enter a 'Authorized value:' and click 'Save' -- This will create it without OPAC and Staff Client descriptions! This is wrong. 6) Apply patch 7) $ ./installer/data/mysql/updatedatabase.pl -- expecting atomic update to run. 8) Refresh staff client page -- the descriptions should now be filled in. 9) Repeat steps 4 and 5 -- This time, you will be given two error messages -- Nothing will be created. 10) Attempt to create a new authorized value with descriptions. -- should save without issue. 11) Run koha qa test tools -- SQL files are unchecked, but steps 7 & 8 confirm validity. -- Should be no issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37532|0 |1 is obsolete| | Attachment #37784|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37785&action=edit Bug 13399: Missing validation on authorised value descriptions This adds validations which force both the OPAC and Staff Client authorized value descriptions to be filled in. TEST PLAN --------- 1) Login to staff client 2) Koha administration -> Authorized values 3) Change drop-down to 'DEPARTMENT' -- Assuming you have default values installed, and DEPARTMENT exists. 4) Click '+ New authorized value for DEPARTMENT' 5) Enter a 'Authorized value:' and click 'Save' -- This will create it without OPAC and Staff Client descriptions! This is wrong. 6) Apply patch 7) $ ./installer/data/mysql/updatedatabase.pl -- expecting atomic update to run. 8) Refresh staff client page -- the descriptions should now be filled in. 9) Repeat steps 4 and 5 -- This time, you will be given two error messages -- Nothing will be created. 10) Attempt to create a new authorized value with descriptions. -- should save without issue. 11) Run koha qa test tools -- SQL files are unchecked, but steps 7 & 8 confirm validity. -- Should be no issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't think this is the correct solution. There are reasons why it makes sometimes sense to leave one or both descriptions empty. In the past Koha even came with 0 values that had empty descriptions to offer an empty entry in some pull down lists. Also, if you leave the OPAC description empty it will fall back to the library description as a feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- And is this really a bug? What if a library just doesn't want to display anything in department and term? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #12)
And is this really a bug? What if a library just doesn't want to display anything in department and term?
Then they wouldn't have entered any authorized values, right? Blanks in dropdowns shouldn't be forced data-entries. They should be added to the dropdowns. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #11)
In the past Koha even came with 0 values that had empty descriptions to offer an empty entry in some pull down lists.
Can you provide a suggestion where to look in the user interface for these types of drop-downs that may require blanks? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Mark, Term and Department are mandatory in the course reserves module - the library is forced to enter an authorized value. Asked the other way around: what negative side effect does it have to not enforce entering a subscription? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org