[Bug 33272] New: Color of the "(remove)" link when an item is in the cart (OPAC)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Bug ID: 33272 Summary: Color of the "(remove)" link when an item is in the cart (OPAC) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When search results are in the cart, there is a "In your cart (remove)" mention under the search result. The "(remove)" part is either blue or red depending on the background color/if the search result is even or odd. To replicate: 1. Make a search in the OPAC that will give you 3+ results 2. Check the first three results and select "Add to: Cart" at the top of the results --> Note that for the first result, "In you cart (remove)" is blue --> Note that for the second result, the (remove) part is red --> The third result is like the first -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148520&action=edit Bug 33272: Color of the "(remove)" link when an item is in the cart (OPAC) This patch improves the CSS for styling the OPAC cart's "remove" link in search results so that the color is consistent within alternating table row colors. To test, apply the patch and rebuild the OPAC CSS. - Perform a search in the OPAC which will return multiple results. - Click the "Add to cart" link next to multiple results. - The "remove" link which appears should be the correct red color whether the table row background is white or grey. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148520|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 148548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148548&action=edit Bug 33272: Color of the "(remove)" link when an item is in the cart (OPAC) This patch improves the CSS for styling the OPAC cart's "remove" link in search results so that the color is consistent within alternating table row colors. To test, apply the patch and rebuild the OPAC CSS. - Perform a search in the OPAC which will return multiple results. - Click the "Add to cart" link next to multiple results. - The "remove" link which appears should be the correct red color whether the table row background is white or grey. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148548|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 149072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149072&action=edit Bug 33272: Color of the "(remove)" link when an item is in the cart (OPAC) This patch improves the CSS for styling the OPAC cart's "remove" link in search results so that the color is consistent within alternating table row colors. To test, apply the patch and rebuild the OPAC CSS. - Perform a search in the OPAC which will return multiple results. - Click the "Add to cart" link next to multiple results. - The "remove" link which appears should be the correct red color whether the table row background is white or grey. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jacob.omara@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 --- Comment #6 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Does not apply clean in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151167&action=edit k -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org