[Bug 30130] New: Allow setting EDI type at the vendor level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Bug ID: 30130 Summary: Allow setting EDI type at the vendor level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Currently, EDI has some codepaths that are different depending on a hard coded list of vendors that support the EDItEUR standard (as apposed to the BIC standard). We should allow setting this flag at the vendor definition level in the UI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130852&action=edit Bug 30130: Add standard to edi account definition This patch add a 'standard' field to the edifact account configuration area to allow setting the message standard as either 'EDItEUR' or 'BiC'. This just replaces the currently hard coded hash of SAN's in Koha::Edifact::Order to distinguish between the two standards instead of requireing a bug submission per vender san we identify to be a BiC type vendor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130860&action=edit Bug 30130: (follow-up) Set BiC for 'Ulverscroft' The 'Ulverscroft' supplier is also a BiC follower, this patch adds their SAN, 5013546031839, to the DB update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jon.turner@ptfs-europe.com, | |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Having the descriptions come from the .pl file doesn't sit well with me. Although I think in these cases a change for translation is probably unlikely. If something else was to be added, like an explanatory note, we for sure would need to move it out to the templates. Maybe we could consider moving it anyway for better coding practice? 2) I think QA would love some unit tests on the change in Order.pm 3) Schema change should have been a separate patch ;) All those are not being blockers for my sign-off, but: 4) The summary table shows the code instead of the description. The form and the summary table should match up. 5) The atomic file needs the executable flag to be added (I had done this in a follow-up, but I think better you do it when fixing 4) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130960&action=edit Bug 30130: (QA follow-up) Move description to template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130852|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130860|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130960|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130966&action=edit Bug 30130: Add standard field to edi_account This patch add a 'standard' field to the edifact account configuration table to allow setting the message standard as either 'EDItEUR' or 'BiC'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130967&action=edit Bug 30130: DBIC Update This patch updates the DBIC schema's with the new 'standard' field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130968&action=edit Bug 30130: Use new standard field in account definition This patch uses the new 'standard' field to in the edifact account configuration area to allow setting the message standard as either 'EDItEUR' or 'BiC'. This just replaces the currently hard coded hash of SAN's in Koha::Edifact::Order to distinguish between the two standards instead of requireing a bug submission per vender san we identify to be a BiC type vendor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130969&action=edit Bug 30130: (follow-up) Set BiC for 'Ulverscroft' The 'Ulverscroft' supplier is also a BiC follower, this patch adds their SAN, 5013546031839, to the DB update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130970&action=edit Bug 30130: Unit tests This patch adds a unit test for the internal 'beginning_of_message' method in Koha::Edifact::Order to check that the vendor standard parameter is being interpreted coorectly. Test plan 1. Run the tests, they should pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Patches split as requested, tests added as requested, translations moved as requested.. back to NSO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130966|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130991&action=edit Bug 30130: Add standard field to edi_account This patch add a 'standard' field to the edifact account configuration table to allow setting the message standard as either 'EDItEUR' or 'BiC'. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130967|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130992&action=edit Bug 30130: DBIC Update This patch updates the DBIC schema's with the new 'standard' field. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130968|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130993&action=edit Bug 30130: Use new standard field in account definition This patch uses the new 'standard' field to in the edifact account configuration area to allow setting the message standard as either 'EDItEUR' or 'BiC'. This just replaces the currently hard coded hash of SAN's in Koha::Edifact::Order to distinguish between the two standards instead of requireing a bug submission per vender san we identify to be a BiC type vendor. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130969|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130994&action=edit Bug 30130: (follow-up) Set BiC for 'Ulverscroft' The 'Ulverscroft' supplier is also a BiC follower, this patch adds their SAN, 5013546031839, to the DB update. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130970|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130995&action=edit Bug 30130: Unit tests This patch adds a unit test for the internal 'beginning_of_message' method in Koha::Edifact::Order to check that the vendor standard parameter is being interpreted coorectly. Test plan 1. Run the tests, they should pass Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130996&action=edit Bug 30130: (QA follow-up) Fix permission on atomic update file Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130991|0 |1 is obsolete| | Attachment #130992|0 |1 is obsolete| | Attachment #130993|0 |1 is obsolete| | Attachment #130994|0 |1 is obsolete| | Attachment #130995|0 |1 is obsolete| | Attachment #130996|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132404&action=edit Bug 30130: Add standard field to edi_account This patch add a 'standard' field to the edifact account configuration table to allow setting the message standard as either 'EDItEUR' or 'BiC'. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132405&action=edit Bug 30130: DBIC Update This patch updates the DBIC schema's with the new 'standard' field. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132406&action=edit Bug 30130: Use new standard field in account definition This patch uses the new 'standard' field to in the edifact account configuration area to allow setting the message standard as either 'EDItEUR' or 'BiC'. This just replaces the currently hard coded hash of SAN's in Koha::Edifact::Order to distinguish between the two standards instead of requireing a bug submission per vender san we identify to be a BiC type vendor. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132407&action=edit Bug 30130: (follow-up) Set BiC for 'Ulverscroft' The 'Ulverscroft' supplier is also a BiC follower, this patch adds their SAN, 5013546031839, to the DB update. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132408&action=edit Bug 30130: Unit tests This patch adds a unit test for the internal 'beginning_of_message' method in Koha::Edifact::Order to check that the vendor standard parameter is being interpreted coorectly. Test plan 1. Run the tests, they should pass Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132409&action=edit Bug 30130: (QA follow-up) Fix permission on atomic update file Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132410&action=edit Bug 30130: (QA follow-up) Fix tests Result was copied and pasted, needed to update check Was passing objetc instead of standard field Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |There are two predominant release notes| |competing EDI standards, | |EDItEUR and BiC, with | |subtle differences in how | |they interpret some EDI | |message fields. | | | |This patch | |allows administrators to | |pick which standard the | |Vendor is conforming to | |rather than using a | |hardcoded and un-maintained | |SAN mapping in the module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Keywords| |Manual-updated -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org