[Bug 27440] New: Improve structure and style of result toolbars in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Bug ID: 27440 Summary: Improve structure and style of result toolbars in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Several pages in the OPAC follow a similar pattern: Above the table of records (search results, lists, suggestions, etc) is a toolbar with various controls: Highlight, select all, place hold, etc. I think some improvements can be made to the markup and style of these areas of the template to make them work better and look more consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115210&action=edit Bug 27440: Improve structure and style of result toolbars in the OPAC This patch makes markup and CSS changes to areas of the OPAC classed with "selections-toolbar," an area of controls found at the top of some lists of titles: The cart, search results, search history, lists, and suggestions. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Perform a search in the OPAC. On the search results page, confirm that the various controls work correctly: - With OpacHighlightedWords enabled, hightlight and unhighlight links - Select all and clear all links - Selecting one or more checkboxes should enable the "Select titles to..." menu. - Test that adding items to the cart and lists works correctly. - Test that placing multiple holds work. - Test that tagging multiple items works. - From the search results page, add multiple items to the cart. - Open the cart and confirm that the the controls described above continue to work correctly. - Open the search history page, confirm that the toolbar controls work correctly for all four categories: Current session catalog searches; previous session catalog searches; current session authority searches; previous session authority searches. - On the purchase suggestions page, confirm that "select all" and "clear all" work, and that deleting multiple suggestions from the toolbar link works. - On the list contents page test the same controls: selection, multi-hold, tagging, and "Remove from list." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115210|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115342&action=edit Bug 27440: Improve structure and style of result toolbars in the OPAC This patch makes markup and CSS changes to areas of the OPAC classed with "selections-toolbar," an area of controls found at the top of some lists of titles: The cart, search results, search history, lists, and suggestions. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Perform a search in the OPAC. On the search results page, confirm that the various controls work correctly: - With OpacHighlightedWords enabled, hightlight and unhighlight links - Select all and clear all links - Selecting one or more checkboxes should enable the "Select titles to..." menu. - Test that adding items to the cart and lists works correctly. - Test that placing multiple holds work. - Test that tagging multiple items works. - From the search results page, add multiple items to the cart. - Open the cart and confirm that the the controls described above continue to work correctly. - Open the search history page, confirm that the toolbar controls work correctly for all four categories: Current session catalog searches; previous session catalog searches; current session authority searches; previous session authority searches. - On the purchase suggestions page, confirm that "select all" and "clear all" work, and that deleting multiple suggestions from the toolbar link works. - On the list contents page test the same controls: selection, multi-hold, tagging, and "Remove from list." Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I like the consistency this introduces, and working through the test plan yielded no failures.. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27493 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115342|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115911&action=edit Bug 27440: Improve structure and style of result toolbars in the OPAC This patch makes markup and CSS changes to areas of the OPAC classed with "selections-toolbar," an area of controls found at the top of some lists of titles: The cart, search results, search history, lists, and suggestions. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Perform a search in the OPAC. On the search results page, confirm that the various controls work correctly: - With OpacHighlightedWords enabled, hightlight and unhighlight links - Select all and clear all links - Selecting one or more checkboxes should enable the "Select titles to..." menu. - Test that adding items to the cart and lists works correctly. - Test that placing multiple holds work. - Test that tagging multiple items works. - From the search results page, add multiple items to the cart. - Open the cart and confirm that the the controls described above continue to work correctly. - Open the search history page, confirm that the toolbar controls work correctly for all four categories: Current session catalog searches; previous session catalog searches; current session authority searches; previous session authority searches. - On the purchase suggestions page, confirm that "select all" and "clear all" work, and that deleting multiple suggestions from the toolbar link works. - On the list contents page test the same controls: selection, multi-hold, tagging, and "Remove from list." Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115911|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115925&action=edit Bug 27440: Improve structure and style of result toolbars in the OPAC This patch makes markup and CSS changes to areas of the OPAC classed with "selections-toolbar," an area of controls found at the top of some lists of titles: The cart, search results, search history, lists, and suggestions. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Perform a search in the OPAC. On the search results page, confirm that the various controls work correctly: - With OpacHighlightedWords enabled, hightlight and unhighlight links - Select all and clear all links - Selecting one or more checkboxes should enable the "Select titles to..." menu. - Test that adding items to the cart and lists works correctly. - Test that placing multiple holds work. - Test that tagging multiple items works. - From the search results page, add multiple items to the cart. - Open the cart and confirm that the the controls described above continue to work correctly. - Open the search history page, confirm that the toolbar controls work correctly for all four categories: Current session catalog searches; previous session catalog searches; current session authority searches; previous session authority searches. - On the purchase suggestions page, confirm that "select all" and "clear all" work, and that deleting multiple suggestions from the toolbar link works. - On the list contents page test the same controls: selection, multi-hold, tagging, and "Remove from list." Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Added missing signed-off-by line from QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Before: https://snipboard.io/6A5Hbw.jpg After : https://snipboard.io/rcvjpn.jpg On Firefox. 1. I don't think the green is nice and it's not the same as the "Go" button in the header. 2. Is the style change of the dropdown (Add to) expected? Looks nicer before IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- The style of the dropdown is expected. The style is added in order to make the dropdowns consistent with each other. For example, here's what it looks like before the patch in Firefox on macOS: https://snipboard.io/SDwj8y.jpg The color green is different than the "Go" button because it's disabled. Here's the enabled state: https://snipboard.io/Lzy1cS.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon@hse.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27731 [Bug 27731] Place hold link for individual OPAC search result broken -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org