[Bug 10911] New: Records with 880 fields have broken details links in intranet search results using XSLT.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 Bug ID: 10911 Summary: Records with 880 fields have broken details links in intranet search results using XSLT. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Koha intranet search results using XSLT for records with 880 fields have the details link created by a code path that incorrectly links to some opac pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4285 Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21213&action=edit Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT. Koha intranet search results using XSLT for records with 880 fields have the details link created by a code path that incorrectly links to some opac pages. Test Plan: 1) Enable XSLT for intranet search results 2) Upload or create a record with at least one 880 field 3) Search for the item ( must have multiple hits to avoid redirection ) 4) Click the title link, note it is broken 5) Apply this patch 6) Click the title link, note it is correct -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21214&action=edit Example record with 880 fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21213|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21305&action=edit [SIGNED-OFF] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT. Koha intranet search results using XSLT for records with 880 fields have the details link created by a code path that incorrectly links to some opac pages. Test Plan: 1) Enable XSLT for intranet search results 2) Upload or create a record with at least one 880 field 3) Search for the item ( must have multiple hits to avoid redirection ) 4) Click the title link, note it is broken 5) Apply this patch 6) Click the title link, note it is correct Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no koha-qa errors. Test 1) imported two times sample record 2) reindex 3) search, find example record, broken links 4) applied patch 5) refresh, good links NOTE: A similar (invalid references) problem is present on UNIMARC and NORMAC files I'll file a new bug for those cases. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21305|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21308&action=edit [PASSED QA] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT. Koha intranet search results using XSLT for records with 880 fields have the details link created by a code path that incorrectly links to some opac pages. Test Plan: 1) Enable XSLT for intranet search results 2) Upload or create a record with at least one 880 field 3) Search for the item ( must have multiple hits to avoid redirection ) 4) Click the title link, note it is broken 5) Apply this patch 6) Click the title link, note it is correct Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no koha-qa errors. Test 1) imported two times sample record 2) reindex 3) search, find example record, broken links 4) applied patch 5) refresh, good links NOTE: A similar (invalid references) problem is present on UNIMARC and NORMAC files I'll file a new bug for those cases. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, tested with a different set of sample records with Hebrew 880 fields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org