[Bug 29997] New: Allow to send email notification when a serial issue is late
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Bug ID: 29997 Summary: Allow to send email notification when a serial issue is late Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 130048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130048&action=edit Bug 29997: Allow to send email notification when a serial issue is late This patch adds the ability to define, for each subscription, a letter that will be sent whenever an issue is automatically marked as late by the script misc/cronjobs/serialsUpdate.pl. If no letter is defined for a subscription, then no letter will be sent. The letter will be sent to the subscription's manager (the staff member who created or last modified the subscription). Test plan: 1. Create a letter in Tools › Notices & slips for module "Serials". Fill the Email template. 2. Create a new subscription, with a grace period of 1 day, and set the new field "Late issue notification" to the letter you just created. Set the first issue publication date and subscription start date to two days ago 3. Run `misc/cronjobs/serialsUpdate.pl -v -c`. 4. The first serial issue of your subscription should have been automatically marked as late. Now verify that the table message_queue contains a new message corresponding to this serial issue. The message's contents should be what you defined in step 1. The message should be addressed to the subscription's manager (you) Technical note: The "subscription" table contained a column named "librarian", which contained the userid of the patron who created or last modified the subscription, but there was no foreign key constraint referencing the borrowers table. So this patch also adds a new column "manager_id" which contains the borrowernumber of the patron who created or last modified the subscription, and it also adds the foreign key constraint. The atomicupdate script tries to fill the new "manager_id" column by searching patrons by their "userid", which might fail, so it's normal to have some NULL values in "manager_id" at the end. The "librarian" column is removed at the end of the script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30096 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 [Bug 30096] Allow to change "late issue notification" setting in subscriptions batch modification tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130048|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 143637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143637&action=edit Bug 29997: Allow to send email notification when a serial issue is late This patch adds the ability to define, for each subscription, a letter that will be sent whenever an issue is automatically marked as late by the script misc/cronjobs/serialsUpdate.pl. If no letter is defined for a subscription, then no letter will be sent. The letter will be sent to the subscription's manager (the staff member who created or last modified the subscription). Test plan: 1. Run updatedatabase.pl and update_dbix_class_files.pl 2. Create a letter in Tools › Notices & slips for module "Serials". Fill the Email template. 3. Create a new subscription, with a grace period of 1 day, and set the new field "Late issue notification" to the letter you just created. Set the first issue publication date and subscription start date to two days ago 4. Run `misc/cronjobs/serialsUpdate.pl -v -c`. 5. The first serial issue of your subscription should have been automatically marked as late. Now verify that the table message_queue contains a new message corresponding to this serial issue. The message's contents should be what you defined in step 1. The message should be addressed to the subscription's manager (you) Technical note: The "subscription" table contained a column named "librarian", which contained the userid of the patron who created or last modified the subscription, but there was no foreign key constraint referencing the borrowers table. So this patch also adds a new column "manager_id" which contains the borrowernumber of the patron who created or last modified the subscription, and it also adds the foreign key constraint. The atomicupdate script tries to fill the new "manager_id" column by searching patrons by their "userid", which might fail, so it's normal to have some NULL values in "manager_id" at the end. The "librarian" column is removed at the end of the script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased on master + fixed a bug (hardcoded letter code) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143637|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 156796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156796&action=edit Bug 29997: Allow to send email notification when a serial issue is late This patch adds the ability to define, for each subscription, a letter that will be sent whenever an issue is automatically marked as late by the script misc/cronjobs/serialsUpdate.pl. If no letter is defined for a subscription, then no letter will be sent. The letter will be sent to the subscription's manager (the staff member who created or last modified the subscription). Test plan: 1. Run updatedatabase.pl and update_dbix_class_files.pl 2. Create a letter in Tools › Notices & slips for module "Serials". Fill the Email template. 3. Create a new subscription, with a grace period of 1 day, and set the new field "Late issue notification" to the letter you just created. Set the first issue publication date and subscription start date to two days ago 4. Run `misc/cronjobs/serialsUpdate.pl -v -c`. 5. The first serial issue of your subscription should have been automatically marked as late. Now verify that the table message_queue contains a new message corresponding to this serial issue. The message's contents should be what you defined in step 1. The message should be addressed to the subscription's manager (you) Technical note: The "subscription" table contained a column named "librarian", which contained the userid of the patron who created or last modified the subscription, but there was no foreign key constraint referencing the borrowers table. So this patch also adds a new column "manager_id" which contains the borrowernumber of the patron who created or last modified the subscription, and it also adds the foreign key constraint. The atomicupdate script tries to fill the new "manager_id" column by searching patrons by their "userid", which might fail, so it's normal to have some NULL values in "manager_id" at the end. The "librarian" column is removed at the end of the script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |matthias.le-gac@inlibro.com --- Comment #6 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Could you fixed the bug. Applying: Bug 29997: Allow to send email notification when a serial issue is late error: sha1 information is lacking or useless (C4/Serials.pm). error: could not build fake ancestor Patch failed at 0001 Bug 29997: Allow to send email notification when a serial issue is late Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156796|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 175388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175388&action=edit Bug 29997: Allow to send email notification when a serial issue is late This patch adds the ability to define, for each subscription, a letter that will be sent whenever an issue is automatically marked as late by the script misc/cronjobs/serialsUpdate.pl. If no letter is defined for a subscription, then no letter will be sent. The letter will be sent to the subscription's manager (the staff member who created or last modified the subscription). Test plan: 1. Run updatedatabase.pl and update_dbix_class_files.pl 2. Create a letter in Tools › Notices & slips for module "Serials". Fill the Email template. 3. Create a new subscription, with a grace period of 1 day, and set the new field "Late issue notification" to the letter you just created. Set the first issue publication date and subscription start date to two days ago 4. Run `misc/cronjobs/serialsUpdate.pl -v -c`. 5. The first serial issue of your subscription should have been automatically marked as late. Now verify that the table message_queue contains a new message corresponding to this serial issue. The message's contents should be what you defined in step 1. The message should be addressed to the subscription's manager (you) Technical note: The "subscription" table contained a column named "librarian", which contained the userid of the patron who created or last modified the subscription, but there was no foreign key constraint referencing the borrowers table. So this patch also adds a new column "manager_id" which contains the borrowernumber of the patron who created or last modified the subscription, and it also adds the foreign key constraint. The atomicupdate script tries to fill the new "manager_id" column by searching patrons by their "userid", which might fail, so it's normal to have some NULL values in "manager_id" at the end. The "librarian" column is removed at the end of the script Sponsored-by: Écoles Nationales Supérieures d'Architecture -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Keywords| |no-sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175388|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 183390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183390&action=edit Bug 29997: Allow to send email notification when a serial issue is late This patch adds the ability to define, for each subscription, a letter that will be sent whenever an issue is automatically marked as late by the script misc/cronjobs/serialsUpdate.pl. If no letter is defined for a subscription, then no letter will be sent. The letter will be sent to the subscription's manager (the staff member who created or last modified the subscription). Test plan: 1. Run updatedatabase.pl and update_dbix_class_files.pl 2. Create a letter in Tools › Notices & slips for module "Serials". Fill the Email template. 3. Create a new subscription, with a grace period of 1 day, and set the new field "Late issue notification" to the letter you just created. Set the first issue publication date and subscription start date to two days ago 4. Run `misc/cronjobs/serialsUpdate.pl -v -c`. 5. The first serial issue of your subscription should have been automatically marked as late. Now verify that the table message_queue contains a new message corresponding to this serial issue. The message's contents should be what you defined in step 1. The message should be addressed to the subscription's manager (you) Technical note: The "subscription" table contained a column named "librarian", which contained the userid of the patron who created or last modified the subscription, but there was no foreign key constraint referencing the borrowers table. So this patch also adds a new column "manager_id" which contains the borrowernumber of the patron who created or last modified the subscription, and it also adds the foreign key constraint. The atomicupdate script tries to fill the new "manager_id" column by searching patrons by their "userid", which might fail, so it's normal to have some NULL values in "manager_id" at the end. The "librarian" column is removed at the end of the script Sponsored-by: Écoles Nationales Supérieures d'Architecture -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Automated patch testing results: [PASS] ALL PATCHES APPLY CLEANLY All patches apply successfully to the current codebase. **Patch Results:** [PASS] Bug-29997-Allow-to-send-email-notification-when-a-.patch (ID: 183390) Status: SUCCESS + Patch applies cleanly --- This is an automated message from the patch testing system. Tested against branch: main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ayoub.glizi-vicioso@inLibro | |.com --- Comment #11 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- There is an error in the Apache 2 log: Unknown column 'librarian' in 'INSERT INTO'. This occurs when adding a new subscription. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183390|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 207073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207073&action=edit Bug 29997: Allow to send email notification when a serial issue is late This patch adds the ability to define, for each subscription, a letter that will be sent whenever an issue is automatically marked as late by the script misc/cronjobs/serialsUpdate.pl. If no letter is defined for a subscription, then no letter will be sent. The letter will be sent to the subscription's manager (the staff member who created or last modified the subscription). Test plan: 1. Run updatedatabase.pl and update_dbix_class_files.pl 2. Create a letter in Tools › Notices & slips for module "Serials". Fill the Email template. 3. Create a new subscription, with a grace period of 1 day, and set the new field "Late issue notification" to the letter you just created. Set the first issue publication date and subscription start date to two days ago 4. Run `misc/cronjobs/serialsUpdate.pl -v -c`. 5. The first serial issue of your subscription should have been automatically marked as late. Now verify that the table message_queue contains a new message corresponding to this serial issue. The message's contents should be what you defined in step 1. The message should be addressed to the subscription's manager (you) Technical note: The "subscription" table contained a column named "librarian", which contained the userid of the patron who created or last modified the subscription, but there was no foreign key constraint referencing the borrowers table. So this patch also adds a new column "manager_id" which contains the borrowernumber of the patron who created or last modified the subscription, and it also adds the foreign key constraint. The atomicupdate script tries to fill the new "manager_id" column by searching patrons by their "userid", which might fail, so it's normal to have some NULL values in "manager_id" at the end. The "librarian" column is removed at the end of the script Sponsored-by: Écoles Nationales Supérieures d'Architecture -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Ayoub Glizi-Vicioso from comment #11)
There is an error in the Apache 2 log: Unknown column 'librarian' in 'INSERT INTO'. This occurs when adding a new subscription.
attachment 183390 was badly rebased. Sorry about that. This is fixed in the latest patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nathalie.savarit@univ-amu.f | |r -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org