https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34860 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155966&action=edit Bug 34860: New framework plugin for ISBN/ISSN A Koha patch should still be submitted. The REST API does not yet support an index search like the one in isbn_count. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34860 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Added concept code for now. Not yet ready for inclusion. The svc/isbn_count does the index search. The isbn.js includes checking the validity of ISBN on client side. As to hyphenation, I have chosen the following approach: LOC seems to recommend no hyphens in 020 and one hypen in 022 for the MARC fields. When displaying you can add the hyphens for ISBN. The code here removes the hyphens from ISBN when searching the index and does also replace the contents of 020 when hyphens were entered. (The current version removes additional text too..)

From 2013 onwards, additional text should actually be in $q.

In order to make this ready for submittal, the following is probably needed: - proper handling of $a suffixes for 020/022 (We may still assume presence.) - allow hyphenation for ISBN in MARC (index, db) - Pref needed? - removing code overlap between isbn/issn code in js - prepare transition from svc script to REST API - the red or green color approach might be replaced by an alert Please do not hesitate to give your feedback. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34860 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Code with optional suffix stripping: function isbn_check ( subfield, strip_suffix ) { // Remove hyphens from isbn part, handle suffix by split on space var split_field = subfield.split( ' ', 2 ); var isbn = split_field[0].replace( /[-]/g, '' ); var suffix; if( strip_suffix ) suffix = ''; else suffix = split_field[1] ? ' ' + split_field[1] : ''; if ( isbn.match(/^\d{9}(\d{3})?[0-9X]$/) ) { if( valid_isbn_check_digit(isbn) ) return [ 1, isbn + suffix ]; } return [ 0, isbn + suffix ]; } -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34860 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155966|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 155966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155966 Bug 34860: New framework plugin for ISBN/ISSN This version is obsolete. I will upload an new version later on. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34860 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy@rijksmuseum.nl |koha-bugs@lists.koha-commun | |ity.org --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4)

Comment on attachment 155966 [details] [review] Bug 34860: New framework plugin for ISBN/ISSN

This version is obsolete. I will upload an new version later on.

Abandoning. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34860 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|CONFIRMED |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.