[Bug 34573] New: Inconsistencies in acquisitions modify vendor title tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Bug ID: 34573 Summary: Inconsistencies in acquisitions modify vendor title tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.auld@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org When checking bug #33908 I noticed that the title tag for 'My Vendor > Modify My Vendor' doesn't include 'Modify My Vendor'. It is the same as the title tag for the 'My Vendor' page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Templates Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this is still the case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159162&action=edit Bug 34573: Fix inconsistencies in acquisitions modify vendor title tag This patch updates the vendor details template so that the title tag correctly reflects whether the user is viewing the vendor or modifying it. To test, apply the patch and go to Acquisitions. - Locate a vendor and view the details (supplier.pl?booksellerid=X) - The title should read "Vendor X > Acquisitions > Koha" - Edit the vendor. - The title should read "Modify vendor X > Acquisitions > Koha" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159162|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 159183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159183&action=edit Bug 34573: Fix inconsistencies in acquisitions modify vendor title tag This patch updates the vendor details template so that the title tag correctly reflects whether the user is viewing the vendor or modifying it. To test, apply the patch and go to Acquisitions. - Locate a vendor and view the details (supplier.pl?booksellerid=X) - The title should read "Vendor X > Acquisitions > Koha" - Edit the vendor. - The title should read "Modify vendor X > Acquisitions > Koha" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 159184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159184&action=edit Bug 34573: (follow-up) Additional updates for modify vendor page Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD) - see item 3 for additional changes made in a follow-up patch: 1. Page for a vendor ~~~~~~~~~~~~~~~~~~~~ Browser page title - Before: Vendor My Vendor > Koha - After: Vendor My Vendor > Acquisitions > Koha (Acquisitions added) Breadcrumb: - Before: Acquisitions > My Vendor - After: Acquisitions > My Vendor (no change) Page title - Before: My Vendor - After: My Vendor (no change) 2. Page for editing a vendor ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Browser page title: - Browser page tite: Vendor My Vendor > Koha - After: Modify vendor My Vendor > Acquisitions > Koha (Modify added at the start, Acquisitions added) Breadcrumb: - Breadcrumb: Acquisitions > My Vendor > Modify My Vendor - After: Acquisitions > My Vendor > Modify vendor My Vendor (vendor added) Page title: - Page title: Update: My Vendor - After: Update: My Vendor (no change) 3. Additional changes added in follow-up patch for editing a vendor ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I've made some additional changes to the edit vendor page - feel free to obsolete patch if I've got the patter wrong! Browser page title: - Browser page tite: Modify vendor My Vendor > Acquisitions > Koha (Bug 34573: Modify added at the start, Acquisitions added) - After: Modify vendor 'My Vendor' > Acquisitions > Koha (add single quotes around vendor name) Breadcrumb: - Breadcrumb: Acquisitions > My Vendor > Modify vendor My Vendor (Bug 34573: vendor added) - After: Acquisitions > My Vendor > Modify vendor 'My Vendor' (add single quotes around vendor name) Page for editing a vendor: - Page title: Update: My Vendor - After: Modify vendor 'My Vendor' (text before changed, added single quotes around vendor name) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: String changes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159183|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 159435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159435&action=edit Bug 34573: Fix inconsistencies in acquisitions modify vendor title tag This patch updates the vendor details template so that the title tag correctly reflects whether the user is viewing the vendor or modifying it. To test, apply the patch and go to Acquisitions. - Locate a vendor and view the details (supplier.pl?booksellerid=X) - The title should read "Vendor X > Acquisitions > Koha" - Edit the vendor. - The title should read "Modify vendor X > Acquisitions > Koha" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159184|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 159436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159436&action=edit Bug 34573: (follow-up) Additional updates for modify vendor page Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I found some oddness here: When adding a new vendor, the title tag reads: "Modify vendor ''". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 --- Comment #10 from David Nind <david@davidnind.com> --- I thought I might have caused it, but it is something to do with line 150 (after the patches are applied) - that text appears in the HTML page title if you add a new vendor or modify an existing vendor. I don't understand how it works enough to fix it 8-(. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167540&action=edit Bug 34573: (follow-up) Add better logic for add/update title and headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes page title, release notes| |breadcrumb, and browser | |page title inconsistencies | |when adding and modifying | |vendor details in | |acquisitions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.02 released in| | CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.02 |24.11.00,24.05.02,23.11.07 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #15 from wainuiwitikapark@catalyst.net.nz --- Patch doesn't apply cleanly to 23.05, not backporting unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org