https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131340&action=edit Bug 30220: Purchase suggestion defaults to first library This patch updates the OPAC suggestions form to update the variable used to pre-select the logged-in user's library. To test, apply the patch and make sure the "suggestion" preference is set to "Allow." - Log in to the OPAC and click "your purchase suggestions" in the sidebar menu on your summary page. - Click "New purchase suggestion." - The selected library should match the logged-in user's home library. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131340|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131341&action=edit Bug 30220: Purchase suggestion defaults to first library This patch updates the OPAC suggestions form to update the variable used to pre-select the logged-in user's library. To test, apply the patch and make sure the "suggestion" preference is set to "Allow." - Log in to the OPAC and click "your purchase suggestions" in the sidebar menu on your summary page. - Click "New purchase suggestion." - The selected library should match the logged-in user's home library. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this did default to the patron's home library in the past, which would make this a regression. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131341|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131414&action=edit Bug 30220: Purchase suggestion defaults to first library This patch updates the OPAC suggestions form to update the variable used to pre-select the logged-in user's library. To test, apply the patch and make sure the "suggestion" preference is set to "Allow." - Log in to the OPAC and click "your purchase suggestions" in the sidebar menu on your summary page. - Click "New purchase suggestion." - The selected library should match the logged-in user's home library. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6)

(In reply to Lucas Gass from comment #3)

...

I would consider this a separate issue, and will file a separate bug, but if you add branchcode to the sys pref OPACSuggestionMandatoryFields the dropdown should default to an empty value in order to force the user into making a choice.

Please do!

Also tested this with an Anonymous suggestoin and there it still defaults to the first entry, which seems ok given the use case.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Andrew Fuerste-Henry from comment #10)

Pushed to 21.05.x for 21.05.14

Cool beans! Thanks Andrew! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@koha-us.org | -- You are receiving this mail because: You are watching all bug changes.