[Bug 16442] New: C4::Ris is not plack safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Bug ID: 16442 Summary: C4::Ris is not plack safe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Blocks: 7172 C4::Ris incorrectly uses 4 package variables: - $utf: not used, can be removed - $intype: set to marcflavour once, but later it assumes that it is usmarc if not defined our $marcprint: always 0, so set it to 0 our $protoyear: only used in 1 subroutine, let's define it at this level Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51219&action=edit Bug 16442: C4::Ris is not plack safe C4::Ris incorrectly uses 4 package variables: - $utf: not used, can be removed - $intype: set to marcflavour once, but later it assumes that it is usmarc if not defined - $marcprint: always 0, so set it to 0 - $protoyear: only used in 1 subroutine, let's define it at this level Test plan: Just make sure the RIS export works as before this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51219|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51221&action=edit Bug 16442: Make C4::Ris plack safe C4::Ris incorrectly uses 4 package variables: - $utf: not used, can be removed - $intype: set to marcflavour once, but later it assumes that it is usmarc if not defined - $marcprint: always 0, so set it to 0 - $protoyear: only used in 1 subroutine, let's define it at this level Test plan: Just make sure the RIS export works as before this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51221|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 51773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51773&action=edit Bug 16442: Make C4::Ris plack safe C4::Ris incorrectly uses 4 package variables: - $utf: not used, can be removed - $intype: set to marcflavour once, but later it assumes that it is usmarc if not defined - $marcprint: always 0, so set it to 0 - $protoyear: only used in 1 subroutine, let's define it at this level Test plan: Just make sure the RIS export works as before this patch Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51773|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 52005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52005&action=edit Bug 16442: Make C4::Ris plack safe C4::Ris incorrectly uses 4 package variables: - $utf: not used, can be removed - $intype: set to marcflavour once, but later it assumes that it is usmarc if not defined - $marcprint: always 0, so set it to 0 - $protoyear: only used in 1 subroutine, let's define it at this level Test plan: Just make sure the RIS export works as before this patch Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16668 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 2 tests from t/Ris.t now fail. See bug 16668 for a fix. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16668 [Bug 16668] Move t/Ris.t to t/db_dependent/Ris.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org