https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71469&action=edit Bug 20178: [sql_modes] Fix output_pref with dateformat=iso Fix for: Incorrect date value: '2018-02-05 06:30 PM' for column 'entrydate' TODO - check other occurrences, put to a separate bug report Then `git grep output_pref|grep iso` and make sure no other calls are impacted. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20008 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71498&action=edit Bug 20178: Fix test - iso formatted dates should not use timeformat -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71469|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 71593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71593&action=edit Bug 20178: [sql_modes] Fix output_pref with dateformat=iso Fix for: Incorrect date value: '2018-02-05 06:30 PM' for column 'entrydate' TODO - check other occurrences, put to a separate bug report Then `git grep output_pref|grep iso` and make sure no other calls are impacted. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Julian Maurice from comment #7)

What if I want to display dates in ISO format but time in 12 hours format ? It is actually possible in master, but this patch prevents this.

ISO format includes times, and they must be 24 hour. This is why I took a little longer signing off, because I had to confirm that 12 hour times were not valid in ISO formatting. You could custom tweak your system preference to something that triggers the fallback else case. :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- It looks like a misuse of output_pref. Shouldn't the result of this subroutine be used only for display ? Anyway there is a lack of documentation here. It should be documented at least in POD and in description of both sysprefs IMO. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|jonathan.druart@bugs.koha-c |chris@bigballofwax.co.nz |ommunity.org | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This need to be fixed globally or at least check all the occurrences to estimate the issue. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20199 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have opened bug 20199 for the Letters.t failure. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure how to test this - can someone tell if it's still valid? -- You are receiving this mail because: You are watching all bug changes.