https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 [Bug 17252] Koha::AuthorisedValues - Remove GetAuthorisedValueByCode -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- fatal: sha1 information is lacking or useless (C4/Items.pm). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55187|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56244&action=edit Bug 17251: Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping This subroutine was only used once in GetItemsForInventory. It can be replaced with a quite simple search on AV join on authorised_value_categories and marc_subfield_structures tables. Note that the "interface" parameter was always set to "staff" and was useless. Test plan: Play with the inventory and confirm that the AV descriptions are correctly displayed. The tests in t/db_dependent/Items/GetItemsForInventory.t cover this change and should still pass. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Claire Gravely from comment #4)

When trying to access /cgi-bin/koha/admin/authorised_values.pl from the administration page i get this error:

DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_kohadev.authorised_value_categories' doesn't exist at /home/vagrant/kohaclone/Koha/Objects.pm line 120

I also got this when trying to prove the test:

t/db_dependent/Items/GetItemsForInventory.t (Wstat: 512 Tests: 0 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 6 tests but ran 0.

For the record: The DBIx::Class schema files were not up-to-date. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56258|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56392&action=edit [PASSED QA] Bug 17251: Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping This subroutine was only used once in GetItemsForInventory. It can be replaced with a quite simple search on AV join on authorised_value_categories and marc_subfield_structures tables. Note that the "interface" parameter was always set to "staff" and was useless. Test plan: Play with the inventory and confirm that the AV descriptions are correctly displayed. The tests in t/db_dependent/Items/GetItemsForInventory.t cover this change and should still pass. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.