[Bug 19851] New: Improve responsive layout handling of staff client menu bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Bug ID: 19851 Summary: Improve responsive layout handling of staff client menu bar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Created attachment 69952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69952&action=edit Screenshot showing broken layout below 768 pixels wide The built-in Bootstrap responsive layout makes the staff client's menu bar behave badly at browser widths smaller than 768 pixels. I propose to add some CSS to make it work somewhat better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69957&action=edit Screenshot of the proposed updated interface In the proposed revision, the logged-in user's name and branch would move to the dropdown menu at lower screen widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight@lboro.ac.uk --- Comment #2 from Jon Knight <J.P.Knight@lboro.ac.uk> --- That looks much better to me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70023&action=edit Bug 19851: Improve responsive layout handling of staff client menu bar This patch modifies CSS and markup in the staff client header to override the default responsive style of the menu bar. The changed layout will keep the menu bar items in a horizontal line at lower screen widths. To test, apply the patch and clear your browser cache if necessary. - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14546 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70023|0 |1 is obsolete| | --- Comment #4 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 70139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70139&action=edit Bug 19851: Improve responsive layout handling of staff client menu bar This patch modifies CSS and markup in the staff client header to override the default responsive style of the menu bar. The changed layout will keep the menu bar items in a horizontal line at lower screen widths. To test, apply the patch and clear your browser cache if necessary. - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: dom <dominic.pichette@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette@inlibro.co | |m Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70139|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70149&action=edit Bug 19851: Improve responsive layout handling of staff client menu bar This patch modifies CSS and markup in the staff client header to override the default responsive style of the menu bar. The changed layout will keep the menu bar items in a horizontal line at lower screen widths. To test, apply the patch and clear your browser cache if necessary. - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: dom <dominic.pichette@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Status|Signed Off |Passed QA --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Nice job Owen ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20051 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 [Bug 20051] Invalid markup in staff client's header.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- This looks more like enhancement to me. BTW I will wait for Bug 20051 to decide if I backport to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20135 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 [Bug 20135] Staff client language choose pop-up can appear off-screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22023 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org