[Bug 7478] New: Template/translation problem in catalogue_out.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Bug #: 7478 Summary: Template/translation problem in catalogue_out.tt Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N AssignedTo: frederic@tamil.fr ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha.sekjal@gmail.com Spotted while working on a translation bug, reporting so that it does not get lost: intranet-tmpl/prog/en/modules/reports/catalogue_out.tt: [% IF ( looptable.looprow ) %] [% FOREACH loopro IN looptable.looprow %] [% DEFAULT loopro.itemcallnumber="No Call Number" loopro.barcode="No Barcode" loopro.title="NO TITLE" loopro.author="" %] [% UNLESS ( loop.odd ) %]<tr class="highlight"> [% ELSE %]<tr>[% END %] staff po file: %s %s [%% DEFAULT loopro.itemcallnumber=\"No Call Number\" loopro.barcode=\"No Barcode\" loopro.title=\"NO TITLE\" loopro.author=\"\" %%] %s That will not work if translated like that. It also seems like " are escaped in the po files now, which does not seem right to me. There are other examples, that will break things if copied over with espcaped double quotes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20238&action=edit Bug 7478 - Template/translation problem in catalogue_out.tt The items with no checkouts template has a sections that uses DEFAULT to set some strings: [% DEFAULT loopro.itemcallnumber="No Call Number" %] This appears to be untranslatable with our current translation tool. This patch changes the template so that it uses a simple [% IF %] block to display the default text if no value is set. Added is use of the Branches template plugin to show library name instead of code. This patch also fixes an error introduced in my fix for Bug 8124 causing the page to default to CSV download instead of output to screen. To test, apply the patch and confirm that the default text appears onscreen in reports which include results that have a missing barcode, title, or call number. Results should be displayed on screen correctly. Run "perl translate update" for any language and confirm that the newly generated po file includes "No call number," "No barcode," and "NO TITLE" for catalogue_out.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10718 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|frederic@tamil.fr |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20238|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20601&action=edit [SIGNED OFF] Bug 7478 - Template/translation problem in catalogue_out.tt The items with no checkouts template has a sections that uses DEFAULT to set some strings: [% DEFAULT loopro.itemcallnumber="No Call Number" %] This appears to be untranslatable with our current translation tool. This patch changes the template so that it uses a simple [% IF %] block to display the default text if no value is set. Added is use of the Branches template plugin to show library name instead of code. This patch also fixes an error introduced in my fix for Bug 8124 causing the page to default to CSV download instead of output to screen. To test, apply the patch and confirm that the default text appears onscreen in reports which include results that have a missing barcode, title, or call number. Results should be displayed on screen correctly. Run "perl translate update" for any language and confirm that the newly generated po file includes "No call number," "No barcode," and "NO TITLE" for catalogue_out.tt Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, thx Owen! Applied on top of 10718 for testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20601|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20701&action=edit Bug 7478 - Template/translation problem in catalogue_out.tt The items with no checkouts template has a sections that uses DEFAULT to set some strings: [% DEFAULT loopro.itemcallnumber="No Call Number" %] This appears to be untranslatable with our current translation tool. This patch changes the template so that it uses a simple [% IF %] block to display the default text if no value is set. Added is use of the Branches template plugin to show library name instead of code. This patch also fixes an error introduced in my fix for Bug 8124 causing the page to default to CSV download instead of output to screen. To test, apply the patch and confirm that the default text appears onscreen in reports which include results that have a missing barcode, title, or call number. Results should be displayed on screen correctly. Run "perl translate update" for any language and confirm that the newly generated po file includes "No call number," "No barcode," and "NO TITLE" for catalogue_out.tt Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, thx Owen! Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |8215 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org