https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Everything looks good except these issues: - The "Cancel checkout and place hold" button isn't working for me. Nothing happens when I click it. - On the batch checkout screen, I don't think it is consistent to add an icon to that button. At this time we don't have a standard of adding icons to every submit button. - Missing closing bracket on line 52 of renew.tt: <button type="submit" class="approve"><i class="fa fa-check"</i> Override limit and renew</button> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48081|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48321&action=edit Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Circulation -> Check out -> An item that is checked out by someone else -> An item that is on hold to someone else -> To a patron that has more than noisuescharge in fines (Allow AllowFineOverride syspref) -> To a patron that has reached the max amount of checkouts (Allow AllowTooManyOverride syspref) -> To a patron that has more than noissuescharge in fines (Allow AllowFineOverride syspref and set noissuescharge syspref) -> Renew -> An item that is on hold to someone else -> To a patron that is at max renewals (Allow AllowRenewalLimitOverride syspref) -> An item that is not checked out by anyone -> Check in -> An item that is in transit to another branch And look for other confirmation dialogs and check if I've missed any Sponsored-by: Catalyst IT EDIT: Made changes from Comment 2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48321|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48366&action=edit [SIGNED-OFF] Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Circulation -> Check out -> An item that is checked out by someone else -> An item that is on hold to someone else -> To a patron that has more than noisuescharge in fines (Allow AllowFineOverride syspref) -> To a patron that has reached the max amount of checkouts (Allow AllowTooManyOverride syspref) -> To a patron that has more than noissuescharge in fines (Allow AllowFineOverride syspref and set noissuescharge syspref) -> Renew -> An item that is on hold to someone else -> To a patron that is at max renewals (Allow AllowRenewalLimitOverride syspref) -> An item that is not checked out by anyone -> Check in -> An item that is in transit to another branch And look for other confirmation dialogs and check if I've missed any Sponsored-by: Catalyst IT EDIT: Made changes from Comment 2 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48366|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48438&action=edit Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Circulation -> Check out -> An item that is checked out by someone else -> An item that is on hold to someone else -> To a patron that has more than noisuescharge in fines (Allow AllowFineOverride syspref) -> To a patron that has reached the max amount of checkouts (Allow AllowTooManyOverride syspref) -> To a patron that has more than noissuescharge in fines (Allow AllowFineOverride syspref and set noissuescharge syspref) -> Renew -> An item that is on hold to someone else -> To a patron that is at max renewals (Allow AllowRenewalLimitOverride syspref) -> An item that is not checked out by anyone -> Check in -> An item that is in transit to another branch And look for other confirmation dialogs and check if I've missed any Sponsored-by: Catalyst IT EDIT: Made changes from Comment 2 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 15681 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16042 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16042 [Bug 16042] Missing closing quote in checkin template -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16215 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 [Bug 16215] Missing closing quote in checkout template -- You are receiving this mail because: You are watching all bug changes.