[Bug 9348] New: Format dates in HOLD notices consistently
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9348 Bug ID: 9348 Summary: Format dates in HOLD notices consistently Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com Right now notices for holds awaiting pickup read something like this: You have a hold available for pickup as of 2011-02-12. This hold will expire if it is not picked up before: 02/22/2011. If you no longer need this item or have any questions please contact us As you can see, we have two different formats for the waiting date and the expiration date. Both dates should be formatting based on the dateformat system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9348 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14412&action=edit Bug 9348 - Format dates in HOLD notices consistently Right now notices for holds awaiting pickup read something like this: You have a hold available for pickup as of 2011-02-12. This hold will expire if it is not picked up before: 02/22/2011. If you no longer need this item or have any questions please contact us Both dates should be formatting based on the dateformat system preference. Test Plan: 1) Apply patch 2) Set the HOLD notice to the following: <<reserves.waitingdate>> / <<reserves.expirationdate>> 3) Place a hold for a patron 4) Enable the HOLD notice via email for that patron ( requires EnhancedMessaging ) 5) Check the item in 6) Go to the borrower's Notices tab, check the body of the new HOLD notice, it should have two dates separated by a '/' in the format set by the dateformat system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9348 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9348 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal@gmail.com --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- *** Bug 6535 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9348 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9348 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9348 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14412|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14429&action=edit [SIGNED-OFF] Bug 9348 - Format dates in HOLD notices consistently Right now notices for holds awaiting pickup read something like this: You have a hold available for pickup as of 2011-02-12. This hold will expire if it is not picked up before: 02/22/2011. If you no longer need this item or have any questions please contact us Both dates should be formatting based on the dateformat system preference. Test Plan: 1) Apply patch 2) Set the HOLD notice to the following: <<reserves.waitingdate>> / <<reserves.expirationdate>> 3) Place a hold for a patron 4) Enable the HOLD notice via email for that patron ( requires EnhancedMessaging ) 5) Check the item in 6) Go to the borrower's Notices tab, check the body of the new HOLD notice, it should have two dates separated by a '/' in the format set by the dateformat system preference. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Patch works as advertised according to the test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9348 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: The patch makes consistent the date formats for some notices. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9348 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14429|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14565&action=edit Bug 9348 - Format dates in HOLD notices consistently Right now notices for holds awaiting pickup read something like this: You have a hold available for pickup as of 2011-02-12. This hold will expire if it is not picked up before: 02/22/2011. If you no longer need this item or have any questions please contact us Both dates should be formatting based on the dateformat system preference. Test Plan: 1) Apply patch 2) Set the HOLD notice to the following: <<reserves.waitingdate>> / <<reserves.expirationdate>> 3) Place a hold for a patron 4) Enable the HOLD notice via email for that patron ( requires EnhancedMessaging ) 5) Check the item in 6) Go to the borrower's Notices tab, check the body of the new HOLD notice, it should have two dates separated by a '/' in the format set by the dateformat system preference. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Patch works as advertised according to the test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9348 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9348 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org