[Bug 7962] New: Cart missing from result lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 Priority: P5 - low Change sponsored?: --- Bug ID: 7962 Assignee: oleonard@myacpl.org Summary: Cart missing from result lists QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Cart button is not shown above result lists in OPAC any longer. FireBug shows a JavaScript error: $("#cartmenulink").hoverIntent is not a function -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- 17:20 ~/kohaclone ((7eef4c8...) %|BISECTING)$ git bisect bad 7eef4c8c700dc81e8ab2fd28486162ff7db35ede is the first bad commit commit 7eef4c8c700dc81e8ab2fd28486162ff7db35ede Bug 5668 - Star ratings in the opac -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Excellent use of git bisect Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Hmmm it is now trying to load jquery twice, could that be the problem? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9210&action=edit [PATCH] Bug 7962 - Cart missing from result lists Removing duplicate inclusion of jQuery on the results page which was added with the star ratings feature. Koha already uses jQuery by default. I have also made the inclusion of ratings JS and CSS dependent on ratings being turned on. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9210|0 |1 is obsolete| | --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9214&action=edit [SIGNED-OFF] Bug 7962 - Cart missing from result lists Removing duplicate inclusion of jQuery on the results page which was added with the star ratings feature. Koha already uses jQuery by default. I have also made the inclusion of ratings JS and CSS dependent on ratings being turned on. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9214|0 |1 is obsolete| | --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Created attachment 9215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9215&action=edit Bug 7962 - Cart missing from result lists Removing duplicate inclusion of jQuery on the results page which was added with the star ratings feature. Koha already uses jQuery by default. I have also made the inclusion of ratings JS and CSS dependent on ratings being turned on. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Mason James <mtj at kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <koha.sekjal@gmail.com> --- Template only change removes duplicate include, and conditionalizes a script and a CSS include based on actual usage. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7962 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org