[Bug 19682] New: Move JS to the footer: Two patron-related tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Bug ID: 19682 Summary: Move JS to the footer: Two patron-related tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: dominic.pichette@inlibro.com, testopia@bugs.koha-community.org Depends on: 19641, 19647 Blocks: 17858 In order to conform to best practices for performance, staff client template JavaScript should be in the footer instead of the header. This patch will do so for two patron-related tools which also incorporate elements from the Patrons module, requiring a dependency on Bug 19641: Import patrons and Upload patron images. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 [Bug 19647] Move patron lists templates JS to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69292&action=edit Bug 19682: Move JS to the footer: Two patron-related tools This patch modifies two patron-related tools templates in the staff client so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Import patrons - Upload patron images -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Hullo, issue when applying dependencies: Applying: Bug 19560: Correctly escape branchcode in admin/branches.pl fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I did some rebasing to other bugs this morning so I think this is ready to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69292|0 |1 is obsolete| | --- Comment #4 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69737&action=edit Bug 19682: Move JS to the footer: Two patron-related tools This patch modifies two patron-related tools templates in the staff client so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Import patrons - Upload patron images Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Bug 19682 depends on bug 19647, which changed state. Bug 19647 Summary: Move patron lists templates JS to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |BLOCKED --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- One of the dependencies is not in the QA queue yet, moving to BLOCKED for now, please move back once dependencies have been sorted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com Status|Signed Off |Failed QA --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- The datepicker in import patrons tool is shown only by dateofbirth field. Should be also on dateexpiry and dateenrolled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69737|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70467&action=edit Bug 19682: Move JS to the footer: Two patron-related tools This patch modifies two patron-related tools templates in the staff client so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Import patrons - Upload patron images Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Edit for QA: Fixed datepickers on import patron form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70467|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71293&action=edit Bug 19682: Move JS to the footer: Two patron-related tools This patch modifies two patron-related tools templates in the staff client so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Import patrons - Upload patron images Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Edit for QA: Fixed datepickers on import patron form Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org