[Bug 22150] New: Make it easier to unselect one member permission after selecting all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Bug ID: 22150 Summary: Make it easier to unselect one member permission after selecting all Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- Go to a patron account page Click more -> Set permissions At the moment, if you select Superlibrarian, it is the same as selecting all. However, you can't then unselect one permission because the checkboxes are disabled. It is very slow and tedious to have to select every other checkbox one by one. There should be a way to disable the checkboxes when I want to unselect one or some permissions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it is on purpose - superlibrarian means all, but it's actually more than 'all'. Superlibrarians can do more than some of the permissions, especially when it comes to Independentbranches. So there would be conflicts if you could have superlibrarian without some of the other permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This conversation has nudged me to rebase my patch for Bug 11375 which redesigns the patron permission interface. I think that even with my redesign this is still an issue. I wonder if it could be solved by adding "check all" and "check none" controls where "check all" would automatically de-select the superlibrarian flag? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Owen Leonard from comment #2)
I think that even with my redesign this is still an issue. I wonder if it could be solved by adding "check all" and "check none" controls where "check all" would automatically de-select the superlibrarian flag?
This is exactly what I had in mind. (In reply to Katrin Fischer from comment #1)
I think it is on purpose - superlibrarian means all, but it's actually more than 'all'. Superlibrarians can do more than some of the permissions, especially when it comes to Independentbranches. So there would be conflicts if you could have superlibrarian without some of the other permissions.
I meant that if you unselected any checkbox, the superlibrarian box would also be unselected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for commenting, I agree! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 --- Comment #5 from Jasmine Amohia <jasmineamohia.student@wegc.school.nz> --- Created attachment 84170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84170&action=edit Bug 22150: Ability to select or unselect all member flags To test: 1) Find a patron 2) Click More -> Set permissions 3) Click 'Clear all', confirm all checkboxes get cleared and disabled 4) Click 'Select all', confirm all checkboxes get selected 5) Unselect one checkbox (not superlibrarian), and confirm that the superlibrarian checkbox also gets unselected 6) Confirm that saving still works as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jasmineamohia.student@wegc. |ity.org |school.nz CC| |jasmineamohia.student@wegc. | |school.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- This works well, but the superlibrarian checkbox shouldn't be checked when you click "Select all." If you check all, including the superlibrarian checkbox, and save, you'll get an error when you return to the permissions page: "Inconsistency detected! The superlibrarian privilege is mutually exclusive of other privileges, as it includes them all. This patron's privileges will now be reset to include only superlibrarian." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amyking386@gmail.com Assignee|jasmineamohia.student@wegc. |amyking386@gmail.com |school.nz | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 --- Comment #7 from Amy King <amyking386@gmail.com> --- Created attachment 115490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115490&action=edit Bug 22150: (follow-up) ensuring superlibrarian flag not checked when select all Test plan: 1. Go to a patron account page 2. Click more, set permissions 3. If you select Superlibrarian, you can't unselect on box. 4. Apply first patch by Jasmine Amohia 5. Follow steps for that patch 6. Apply patch 7. Go through steps 1-4 from Jasmine Amohia, but now notice how when you click "Select all" the Superlibrarian checkbox is not checked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84170|0 |1 is obsolete| | Attachment #115490|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115530&action=edit Bug 22150: Ability to select or unselect all member flags To test: 1) Find a patron 2) Click More -> Set permissions 3) Click 'Clear all', confirm all checkboxes get cleared and disabled 4) Click 'Select all', confirm all checkboxes get selected 5) Unselect one checkbox (not superlibrarian), and confirm that the superlibrarian checkbox also gets unselected 6) Confirm that saving still works as expected Edit: Rebased by Owen Leonard -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115531&action=edit Bug 22150: ensuring superlibrarian flag not checked when select all Test plan: 1. Go to a patron account page 2. Click more, set permissions 3. If you select Superlibrarian, you can't unselect on box. 4. Apply first patch by Jasmine Amohia 5. Follow steps for that patch 6. Apply patch 7. Go through steps 1-4 from Jasmine Amohia, but now notice how when you click "Select all" the Superlibrarian checkbox is not checked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- The original patch no longer applied for me, so I rebased it and reattached both patches. I think this work well now, and have only one question that keeps me from signing off: Should the "Select all" action expand all the hidden permissions? I'm wondering if we should make it clear to the user that they are selecting a lot of things. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think as there are so many it might make it less readable to expand all. I like the behaviour now. Signing off - Owen, if you ant to sign off too, we can count mine for QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115530|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115594&action=edit Bug 22150: Ability to select or unselect all member flags To test: 1) Find a patron 2) Click More -> Set permissions 3) Click 'Clear all', confirm all checkboxes get cleared and disabled 4) Click 'Select all', confirm all checkboxes get selected 5) Unselect one checkbox (not superlibrarian), and confirm that the superlibrarian checkbox also gets unselected 6) Confirm that saving still works as expected Edit: Rebased by Owen Leonard Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115531|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115595&action=edit Bug 22150: ensuring superlibrarian flag not checked when select all Test plan: 1. Go to a patron account page 2. Click more, set permissions 3. If you select Superlibrarian, you can't unselect on box. 4. Apply first patch by Jasmine Amohia 5. Follow steps for that patch 6. Apply patch 7. Go through steps 1-4 from Jasmine Amohia, but now notice how when you click "Select all" the Superlibrarian checkbox is not checked Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115594|0 |1 is obsolete| | Attachment #115595|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115610&action=edit Bug 22150: Ability to select or unselect all member flags To test: 1) Find a patron 2) Click More -> Set permissions 3) Click 'Clear all', confirm all checkboxes get cleared and disabled 4) Click 'Select all', confirm all checkboxes get selected 5) Unselect one checkbox (not superlibrarian), and confirm that the superlibrarian checkbox also gets unselected 6) Confirm that saving still works as expected Edit: Rebased by Owen Leonard Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115610|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115611&action=edit Bug 22150: Ability to select or unselect all member flags To test: 1) Find a patron 2) Click More -> Set permissions 3) Click 'Clear all', confirm all checkboxes get cleared and disabled 4) Click 'Select all', confirm all checkboxes get selected 5) Unselect one checkbox (not superlibrarian), and confirm that the superlibrarian checkbox also gets unselected 6) Confirm that saving still works as expected Edit: Rebased by Owen Leonard Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115612&action=edit Bug 22150: ensuring superlibrarian flag not checked when select all Test plan: 1. Go to a patron account page 2. Click more, set permissions 3. If you select Superlibrarian, you can't unselect on box. 4. Apply first patch by Jasmine Amohia 5. Follow steps for that patch 6. Apply patch 7. Go through steps 1-4 from Jasmine Amohia, but now notice how when you click "Select all" the Superlibrarian checkbox is not checked Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115691&action=edit Bug 22150: (follow-up) ensuring superlibrarian flag not checked when select all Use #flag-0 to select the superlibrarian checkbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 [Bug 28882] Incorrect permissions check client-side -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org