[Bug 32616] New: Add 'page-section' to various acquisitions pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 Bug ID: 32616 Summary: Add 'page-section' to various acquisitions pages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 30952 Blocks: 31757 Several acquisitions templates need to have main content wrapped in a "page-section" container. - acqui/edi_ean.tt - acqui/edifactmsgs.tt - acqui/histsearch.tt - acqui/lateorders.tt - acqui/newordersubscription.tt - acqui/newordersuggestion.tt - acqui/ordered.tt - acqui/spent.tt - acqui/z3950_search.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145240&action=edit Bug 32616: Add 'page-section' to various acquisitions pages This patch adds a "page-section" container div around the main section of cataloging plugins which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Basket -> Create EDIFACT order - Acquisitions -> EDIFACT messages - Acquisitions -> Orders search -> Results - Acquisitions -> Late orders - Acquisitions -> Vendor -> Add to basket -> From a subscription - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Acquisitions -> All available funds -> Ordered - Acquisitions -> All available funds -> Spent - Acquisitions -> Vendor -> Add to basket -> From an external source -> Results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145240|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145241&action=edit Bug 32616: Add 'page-section' to various acquisitions pages This patch adds a "page-section" container div around the main section of acquisitions page which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Basket -> Create EDIFACT order - Acquisitions -> EDIFACT messages - Acquisitions -> Orders search -> Results - Acquisitions -> Late orders - Acquisitions -> Vendor -> Add to basket -> From a subscription - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Acquisitions -> All available funds -> Ordered - Acquisitions -> All available funds -> Spent - Acquisitions -> Vendor -> Add to basket -> From an external source -> Results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145241|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 145247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145247&action=edit Bug 32616: Add 'page-section' to various acquisitions pages This patch adds a "page-section" container div around the main section of acquisitions page which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Basket -> Create EDIFACT order - Acquisitions -> EDIFACT messages - Acquisitions -> Orders search -> Results - Acquisitions -> Late orders - Acquisitions -> Vendor -> Add to basket -> From a subscription - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Acquisitions -> All available funds -> Ordered - Acquisitions -> All available funds -> Spent - Acquisitions -> Vendor -> Add to basket -> From an external source -> Results Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. EDIFACT setup: . Enable EDIFACT . Administration > Acquisition parameters: - EDI accounts > New account > Add details (including 'Orders enabled', details don't need to be valid) - Library EANs > New EAN 2. Suggestions: add a suggestion and change the status to accepted 3. Add to order from a subscription: set up a serial first -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145247|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145338&action=edit Bug 32616: Add 'page-section' to various acquisitions pages This patch adds a "page-section" container div around the main section of acquisitions page which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Basket -> Create EDIFACT order - Acquisitions -> EDIFACT messages - Acquisitions -> Orders search -> Results - Acquisitions -> Late orders - Acquisitions -> Vendor -> Add to basket -> From a subscription - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Acquisitions -> All available funds -> Ordered - Acquisitions -> All available funds -> Spent - Acquisitions -> Vendor -> Add to basket -> From an external source -> Results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tiny note/question: On the EDIFACT messages page there is a page-section with a dialog box within: There are no EDIFACT messages. On other pages we have the alerts/dialogs outside the page section. Maybe we should move this above the page section and make sure the empty page section doesn't display? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.02 |23.05.00,22.11.02,22.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Version(s)|23.05.00,22.11.02,22.11.02 |23.05.00,22.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32616 Bug 32616 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org